[Erc-help] Re: patch: erc-process-boundp-and-processp

[lawrence m. <we...@gm...>]

Edward O'Connor wrote:

[...]

> Here's a new version of the patch. I define a function, erc-processp,
> like so:

> (defun erc-processp (&optional proc)
>   "Non-nil if PROC is a process (or a symbol bound to a process)."
     ^^^
"Return non-nil if PROC is a process (or a symbol bound to a process).
If PROC is nil, the value of `erc-process' is used."

>   (setq proc (or proc 'erc-process))
>   (cond ((null proc) nil)
           ^^^ never reached.
> 	((symbolp proc) (and (boundp proc) (processp (symbol-value proc))))
> 	(t (processp proc))))

How about:

(if (symbolp proc)
    (and (boundp proc) (processp (symbol-value proc)))
  (processp proc))

> Also, I changed what appear to be two typos, one in a docstring, and one
> in erc-nickserv.el (s/slashdot/slashnet/).

> If no one objects, I'll commit this patch tomorrow.

The above isn't really an objection, I just don't think the
elisp byte-compiler is smart enough to optimise the first branch
away :)

The only problem I have with the function is that, in its most
common usage, one passes in a quoted symbol, rather than a
variable.  At first glance then, reading something like
(erc-processp 'erc-process) looks "wrong".  I don't know if
anyone else feels the same.  In that way, the original name,
while more unwieldy, was closer to the meaning.  But perhaps
that's just splitting hairs.

-- 
lawrence mitchell <we...@gm...>