Re: [Erc-help] Minor patch for erc.el

[Mario L. <ml...@de...>]

Commited, thanks for the contribution.

lawrence mitchell <we...@gm...> writes:

> I noticed on <URL:
> http://www.emacswiki.org/cgi-bin/wiki.pl?ErcBugs> that
> ERC-IGNORED-USER-P seems not to DTRT, since it doesn't anchor
> its regexp matching.
>
> Here is a small patch which fixes this.  The function has been
> rewritten to make use of DOLIST, rather than a while loop.
>
> Also included is a fix to erc-smiley-mode (it was missing a
> quote in its module definition)
>
> --8<---------------cut here---------------start------------->8---
> Index: erc.el
> ===================================================================
> RCS file: /cvsroot/erc/erc/erc.el,v
> retrieving revision 1.544
> diff -u -r1.544 erc.el
> --- erc.el	2 Jul 2003 23:42:40 -0000	1.544
> +++ erc.el	25 Jul 2003 16:08:52 -0000
> @@ -5795,10 +5795,10 @@
>    "Takes a full SPEC of a user in the form \"nick!login@host\", and
>  matches against all the regexp's in `erc-ignore-list'.  If anyone
>  match, returns that regexp, and nil otherwise."
> -  (let ((lst (with-current-buffer (erc-server-buffer) erc-ignore-list)))
> -    (while (and lst (not (string-match (car lst) spec)))
> -      (setq lst (cdr lst)))
> -    (and lst (car lst))))
> +  (dolist (ignored (with-current-buffer (erc-server-buffer) erc-ignore-list))
> +    (if (string-match (concat "^"ignored"$") spec)
> +	;; We have `require'd cl, so we can return from the block named nil
> +	(return ignored))))
>
>  (defmacro with-erc-channel-buffer (tgt proc &rest body)
>    "Execute BODY for channel TGT and process PROC."
> @@ -6795,7 +6795,7 @@
>  smiley.el, which is part of Gnus."
>    ((add-hook 'erc-insert-modify-hook 'erc-smiley)
>     (add-hook 'erc-send-modify-hook 'erc-smiley))
> -  ((remove-hook 'erc-insert-modify-hook erc-smiley)
> +  ((remove-hook 'erc-insert-modify-hook 'erc-smiley)
>     (remove-hook 'erc-send-modify-hook 'erc-smiley)))
>
>  (defun erc-smiley ()
> --8<---------------cut here---------------end--------------->8---
>
> -- 
> lawrence mitchell <we...@gm...>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
> _______________________________________________
> Erc-help mailing list
> Erc...@li...
> https://lists.sourceforge.net/lists/listinfo/erc-help
>

-- 
CYa,
  Mario | Debian Developer <URL:http://debian.org/>
        | Get my public key via finger ml...@db...
        | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44