Re: [E-devel] [EGIT] [core/elementary] master 01/01: win: add note for (mis)users of elm_win_window_id_get()

[Tom H. <to...@os...>]

On 17/04/15 08:18, ChunEon Park wrote:
> Poor description.
>
> Rather than excuse,
> Please describe what does user suppose to do with this API.

Are you talking to me or Mike?

Anyhow, even when explained, this is an internal hacky API (if the 
comment is really true), and should not be exposed like this.

--
Tom.

>
> ------------------------------------
> -Regards, Hermet-
>
> -----Original Message-----
> From: "Tom Hacohen"<to...@os...>
> To: "Enlightenment developer list"<enl...@li...>;
> Cc:
> Sent: 2015-04-17 (금) 01:08:08
> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: win: add note for (mis)users of elm_win_window_id_get()
>
> On 16/04/15 17:02, Mike Blumenkrantz wrote:
>> discomfitor pushed a commit to branch master.
>>
>> http://git.enlightenment.org/core/elementary.git/commit/?id=366597b2cb385875f8dcc0a172509e5f70c85a4a
>>
>> commit 366597b2cb385875f8dcc0a172509e5f70c85a4a
>> Author: Mike Blumenkrantz <zm...@os...>
>> Date:   Thu Apr 16 11:58:30 2015 -0400
>>
>>       win: add note for (mis)users of elm_win_window_id_get()
>>
>>       this function has a very small use case. if you are outside of this use case,
>>       use a different function.
>> ---
>>    src/lib/elm_win_legacy.h  2 ++
>>    1 file changed, 2 insertions(+)
>>
>> diff --git a/src/lib/elm_win_legacy.h b/src/lib/elm_win_legacy.h
>> index 9729d8b..42bd662 100644
>> --- a/src/lib/elm_win_legacy.h
>> +++ b/src/lib/elm_win_legacy.h
>> @@ -218,6 +218,8 @@ EAPI void                  elm_win_wm_rotation_preferred_rotation_set(const Evas
>>     *
>>     * @ingroup Win
>>     * @since 1.8
>> + * @note Unless you are getting the window id for the purpose of communicating between client<->compositor over dbus,
>> + * this is definitely not the function you are looking for.
>>     */
>>    EAPI Ecore_Window          elm_win_window_id_get(const Evas_Object *obj);
>>
>>
>
> This is so very bad. There are so many ugly hacks being introduced into
> Elm for the wayland/e stuff. I'm sure there are better ways, and at the
> very least, they should be moved into a different header and not be part
> of the main headers...
>
> --
> Tom.
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>