From: Andrew W. <an...@an...> - 2015-03-26 13:09:57
|
Hi, I registered a phab ticket about eina map_lines iterator not iterating through blank links https://phab.enlightenment.org/T2237 <https://phab.enlightenment.org/T2237> I have a fix for this locally which I would love to push but before that happens It thought I had better ask: Does anyone think that iterating through blank lines will cause problems? I’ve outlined in the issue why I think this is needed and I have updated tests locally to show that line indexes remain the same and that blank lines can be identified with line->length == 0 if you really want to skip blank lines. So - any shouts as to why I shouldn’t commit this change? Thanks, Andrew ----- Andy Williams blog: http://ajwillia.ms web: http://andywilliams.me |