From: Tom H. <tom...@sa...> - 2013-01-30 17:43:19
|
On 30/01/13 17:29, Raphael Kubo da Costa wrote: > Tom Hacohen <tom...@sa...> writes: > >> You only removed code, are you sure we still init everything after your >> changes? >> >> (Sorry, I don't have time to take a look yet). > > I've tried both expedite and loading a few web pages with different > fonts and everything works fine -- the other libraries I mentioned do > not explicitly call FcInit() either; our calls to FcSubstitute() & co. > take care of ultimately calling FcConfigGetCurrent(), which performs the > rest of the initialization [1]. > > [1] http://cgit.freedesktop.org/fontconfig/tree/src/fccfg.c#n37 > > In any case, it's fine to keep the FcInit() call if you really want to > be extra safe. ==24639== 736 (512 direct, 224 indirect) bytes in 2 blocks are definitely lost i n loss record 152 of 189 ==24639== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64 -linux.so) ==24639== by 0x91CE34B: ??? (in /usr/lib/x86_64-linux-gnu/libfontconfig.so.1. 6.2) ==24639== by 0x91CF437: ??? (in /usr/lib/x86_64-linux-gnu/libfontconfig.so.1. 6.2) ==24639== by 0x91CF528: ??? (in /usr/lib/x86_64-linux-gnu/libfontconfig.so.1. 6.2) ==24639== by 0x91D4621: ??? (in /usr/lib/x86_64-linux-gnu/libfontconfig.so.1. 6.2) ==24639== by 0xD2F76F3: ??? (in /lib/x86_64-linux-gnu/libexpat.so.1.5.2) ==24639== by 0xD2F8950: ??? (in /lib/x86_64-linux-gnu/libexpat.so.1.5.2) ==24639== by 0xD2F57C6: ??? (in /lib/x86_64-linux-gnu/libexpat.so.1.5.2) ==24639== by 0xD2F717A: ??? (in /lib/x86_64-linux-gnu/libexpat.so.1.5.2) ==24639== by 0xD2FA75C: XML_ParseBuffer (in /lib/x86_64-linux-gnu/libexpat.so .1.5.2) ==24639== by 0x91D3B71: FcConfigParseAndLoad (in /usr/lib/x86_64-linux-gnu/li bfontconfig.so.1.6.2) ==24639== by 0x91D3E1E: FcConfigParseAndLoad (in /usr/lib/x86_64-linux-gnu/li bfontconfig.so.1.6.2) Evas leaks now... -- Tom. |