Re: [E-devel] E SVN: englebass IN trunk/e/src: bin modules/conf_display modules/conf_edgebindings modules/everything modules/gadman modules/notification modules/pager modules/syscon modules/tiling modules/winlist modules/wizard

[Christopher M. <cp....@sa...>]

On 02/10/12 10:33, Sebastian Dransfeld wrote:
> On 10/02/2012 11:26 AM, Christopher Michael wrote:
>> On 02/10/12 10:07, Sebastian Dransfeld wrote:
>>> On 10/02/2012 11:00 AM, Christopher Michael wrote:
>>>> On 02/10/12 09:54, Enlightenment SVN wrote:
>>>>> Log:
>>>>> e: cleanup layer handling
>>>>>
>>>>>       It seems people put random numbers as layers, so it is better
>>>>> to define
>>>>>       available layer numbers.
>>>>>
>>>>>       This patch also puts popups below fullscreen windows, as it
>>>>> sucks to get
>>>>>       popups during presentations. A better solution is maybe to put
>>>>> popups
>>>>>       above fullscreen, but have a presentation mode to put
>>>>> fullscreen windows
>>>>>       above popups?
>>>>>
>>>>> Author:       englebass
>>>>> Date:         2012-10-02 01:54:35 -0700 (Tue, 02 Oct 2012)
>>>>> New Revision: 77293
>>>>> Trac:         http://trac.enlightenment.org/e/changeset/77293
>>>>>
>>>>> Modified:
>>>>>       trunk/e/src/bin/e_border.c trunk/e/src/bin/e_border.h
>>>>> trunk/e/src/bin/e_container.c trunk/e/src/bin/e_container.h
>>>>> trunk/e/src/bin/e_desklock.c trunk/e/src/bin/e_dnd.c
>>>>> trunk/e/src/bin/e_dnd.h trunk/e/src/bin/e_gadcon_popup.c
>>>>> trunk/e/src/bin/e_grab_dialog.c trunk/e/src/bin/e_hints.c
>>>>> trunk/e/src/bin/e_int_border_menu.c
>>>>> trunk/e/src/bin/e_int_shelf_config.c trunk/e/src/bin/e_moveresize.c
>>>>> trunk/e/src/bin/e_popup.c trunk/e/src/bin/e_popup.h
>>>>> trunk/e/src/bin/e_remember.c trunk/e/src/bin/e_shelf.c
>>>>> trunk/e/src/bin/e_shelf.h trunk/e/src/bin/e_win.c
>>>>> trunk/e/src/bin/e_win.h trunk/e/src/bin/e_zone.c
>>>>> trunk/e/src/bin/e_zone.h
>>>>> trunk/e/src/modules/conf_display/e_int_config_display.c
>>>>> trunk/e/src/modules/conf_edgebindings/e_int_config_edgebindings.c
>>>>> trunk/e/src/modules/everything/evry.c
>>>>> trunk/e/src/modules/gadman/e_mod_gadman.c
>>>>> trunk/e/src/modules/notification/e_mod_popup.c
>>>>> trunk/e/src/modules/pager/e_mod_main.c
>>>>> trunk/e/src/modules/syscon/e_syscon.c
>>>>> trunk/e/src/modules/tiling/e_mod_tilin
>> g.
>>>    c
>>>>>      trunk/e/src/modules/winlist/e_winlist.c
>>>>> trunk/e/src/modules/wizard/e_wizard.c
>>>>>
>>>>
>>>> Just curious...have you also tested these changes with the "mobile"
>>>> config ?
>>>
>>> Nope.
>>>
>>> Does it use a lot of fullscreen windows? Then it will probably have some
>>> issues :)
>>>
>>> S.
>>>
>>
>> It uses fullscreen, and layers.
>>
>
> That's no problem, the question is whether it assumes popups will be
> above fullscreen windows.
>
> S.
>

Well, it could be a problem, yes. I noticed that you changed the code 
for _e_container_layer_map. The mobile stuff also uses similar 
calculations. Perhaps it would be better if e_container_layer_map was 
exposed in the API so that any changes to it do not have to be duplicated?

dh