Re: [E-devel] Function e_dbus_request_name

[Vincent T. <vin...@gm...>]

On Wed, Sep 5, 2012 at 6:31 PM, Lucas De Marchi
<luc...@pr...> wrote:
> On Wed, Sep 5, 2012 at 8:14 AM, Vincent Torri <vin...@gm...> wrote:
>> On Wed, Sep 5, 2012 at 12:28 PM, Carsten Haitzler <ra...@ra...> wrote:
>>> On Wed, 05 Sep 2012 05:39:08 +0000 (GMT) Zbigniew Kosinski
>>> <z.k...@sa...> said:
>>>
>>> what are you doing asking for a NULL name? that's non-sensical. it's definitely
>>> an error in your code. libdbus itself is aborting.
>>>
>>> nb - have u tested strdup(NULL); ? it segv's . glibc people won't likely accept
>>> patches to "check for NULL" as its simply invalid input. :)
>>>
>>> so here is my question. why do you think this routine SHOULD check for null and
>>> return instead of let libdbus abort? considering that e_dbus really has no
>>> magic-number checking and typechecking it in (like evas etc.) and is much more
>>> of a thin wrapper/glue on top of libdbus... why should it NOT abort() to let
>>> you know you have a bug in your code (when that is going to be its general
>>> behavior on invalid input in general given the rest of its code)?
>>
>> better fix the doc, then.
>
> Yeah, if there  was one. This is one of those methods that has no docs.
>
> I'm not going to add docs neither, because we are going to deprecate
> e_dbus very soon.

I hope that you will call it edbus :-)

Vincent