Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Hyoyoung C. <hyo...@gm...>]

On Fri, Apr 27, 2012 at 3:55 PM, cnook <kim...@gm...> wrote:
> Dear all, hello.
>
> I have tried to use the map with the diskselector.
> The attached patch is just draft version for using map.

Is it really draft version? imho, it's too good to be initial version.
i just found few points which can be improved.

1.
 +             if (map == NULL) return EINA_FALSE
  ->           if (!map)

2. indentation near about evas_map_smooth_set()

3. as you said, effects can be more tailored.

>
> BUT.. just remind the Raster's comment "at least it can retain its api"...
> I removed number of letters feature.. when I had changed the diskselector...
> So.. even though an item of diskselector moves right or left side.. the
> item will keep its number of letters..
> means... elm_diskselector_side_text_max_length_set does not work..
> anyhow.. this is the draft version.. I would like to check that the map is
> used properly..  as the Raster's recommends "it really needs to use map"
>
>
> Please review the attached patch. Thanks.
>
> Sincerely,
> Shinwoo Kim.
>
>
> 2011/10/10 Carsten Haitzler <ra...@ra...>
>
>> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo <seo...@gm...
>> >
>> said:
>>
>> at least it can retain its api. :)
>>
>> > Wow this sounds like diskselector needs to be rewritten a lot.
>> >
>> > Daniel Juyung Seo (SeoZ)
>> >
>> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler <ra...@ra...>
>> > wrote:
>> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook <kim...@gm...> said:
>> > >
>> > >> Dear All, Hello!
>> > >>
>> > >> If the diskselector is round mode, the scroller of diskselector has
>> > >> additional items for its rounding(carousel) effect.
>> > >> Previously, elm_diskselector_item_icon_set(); did not care about
>> > >> theses additional items.
>> > >> Please review the attached patch that will care. Thanks.
>> > >
>> > > hmm ok - in svn. not giving this a lot of review. i was reviewing
>> > > diskselector about a week ago or so and realized.. this widget needs a
>> > > major overhaul in internal design and implementation. to implement a
>> > > rounded disk - it really needs to use map, and even then the amount of
>> > > rounding or if any at all should be configurable. it should almost
>> > > definitely implement this with a pan smart like genlist does to allow
>> for a
>> > > virtual pan area (we can make it almost infinite - well make it just
>> very
>> > > very very very large) and based on position int he virtual pan,
>> position
>> > > children (really just use a box with map used to duplicate it on the
>> curved
>> > > or visibile area).
>> > >
>> > > --
>> > > ------------- Codito, ergo sum - "I code, therefore I am"
>> --------------
>> > > The Rasterman (Carsten Haitzler)    ra...@ra...
>> > >
>> > >
>> > >
>> ------------------------------------------------------------------------------
>> > > All the data continuously generated in your IT infrastructure contains
>> a
>> > > definitive record of customers, application performance, security
>> > > threats, fraudulent activity and more. Splunk takes this data and makes
>> > > sense of it. Business sense. IT sense. Common sense.
>> > > http://p.sf.net/sfu/splunk-d2dcopy1
>> > > _______________________________________________
>> > > enlightenment-devel mailing list
>> > > enl...@li...
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >
>> >
>> >
>> ------------------------------------------------------------------------------
>> > All the data continuously generated in your IT infrastructure contains a
>> > definitive record of customers, application performance, security
>> > threats, fraudulent activity and more. Splunk takes this data and makes
>> > sense of it. Business sense. IT sense. Common sense.
>> > http://p.sf.net/sfu/splunk-d2dcopy1
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > enl...@li...
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>>
>>
>> --
>> ------------- Codito, ergo sum - "I code, therefore I am" --------------
>> The Rasterman (Carsten Haitzler)    ra...@ra...
>>
>>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>