From: Cedric B. <ced...@fr...> - 2012-01-23 16:00:57
|
On Mon, Jan 23, 2012 at 4:48 PM, Iván Briano (Sachiel) <sac...@gm...> wrote: > 2012/1/23 Enlightenment SVN <no-...@en...>: >> Log: >> edje: detect when we try to inherit from ourself. >> >> >> Author: cedric >> Date: 2012-01-23 07:45:12 -0800 (Mon, 23 Jan 2012) >> New Revision: 67472 >> Trac: http://trac.enlightenment.org/e/changeset/67472 >> >> Modified: >> trunk/edje/src/bin/edje_cc_handlers.c >> >> Modified: trunk/edje/src/bin/edje_cc_handlers.c >> =================================================================== >> --- trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:17:16 UTC (rev 67471) >> +++ trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:45:12 UTC (rev 67472) >> @@ -2242,6 +2242,14 @@ >> progname, file_in, line - 1, parent_name); >> exit(-1); >> } >> + if (pc2 == pc) >> + { >> + ERR("%s: Error. parse error %s:%i. You are trying to inherit '%s' from itself. That's not possible." >> + "If there is another group of the same name, you want to inherit from that group and have the" >> + "same name as that group, there is a trick ! Just put the inherit before the directive that set" >> + "the name !", progname, file_in, line - 1, parent_name); > > WHAT? Why would you do that? People goes all around fixing > shadowing of variables in the C code and now we are telling people > how to shadow Edje groups? Give me your phone number so I can > direct people asking how to fix the problems cause by this to talk > directly to you. Because we are crazy french ! More seriously, by doing this you can just #include the original elementary theme and change some part in a group without copying code. So a very small and easy to read new theme that will be kept in sync with original one. As for my phone number, I have not setup yet an over priced phone line, but as soon as I have, I will happily give it :) -- Cedric BAIL |