Menu
▾
▴
Re: [E-devel] [Patch][elm_map] Change grid management
|
From: Daniel J. S. <seo...@gm...> - 2011-12-05 12:41:43
|
Yeah as Hermet mentioned, this is one big blob of patch which makes reviewers hard to review. Please separate your patch into a couple for patches for each feature. That will help reviewing and debugging. Thanks. Daniel Juyung Seo (SeoZ) 2011/12/5 ChunEon Park <he...@na...>: > please make one shot one kill. > Final change should not be included here. > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Bluezery"<oh...@gm...> > To: "Enlightenment developer list"<enl...@li...> > Cc: > Sent: 11-12-05(월) 19:38:24 > Subject: [E-devel] [Patch][elm_map] Change grid management > Hi, > There are no caching mechanism in current elm_map. > So, too many network resources are wasted because elm_map keeps only > two grids and already downloaded images are downloaded again and > again. (This also slows the map loading speed) > I have changed this grid management policy. > I have done followings. > 1. Create all grids (all zoom levels) when elm_map_add() is called (No > memory overhead because of sparse matrix) > 2. Clear all grids when map object is deleted. > 3. Loads necessary grids and unloads unused grids when zoom level is changed. > Changed grid management have one weakness that memory and tmp size can > grow bigger while map object is live. > I think it may need API such as elm_map_cache_size_set(). > Finally, I restore the gi->have values. The removal of this is my mistake. > gi->have is needed because I cannot know whether this file is > downloading (just opened and not written) or downloaded state even if > image file exists. > Please review this patch. > Thanks > -- > BRs, > Kim. > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d_______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |