Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

[Vincent T. <vt...@un...>]

On Thu, 28 Apr 2011, Eduardo Felipe wrote:

> Reverting is dangerous. I guess should have written the changes to the
> Changelog myself. Should I write it now or would you do it for me?

do it, so that you'll put exactly what you want.

Vincent

>
> On Thu, Apr 28, 2011 at 4:21 PM, Vincent Torri <vt...@un...> wrote:
>>
>>
>> On Thu, 28 Apr 2011, Vincent Torri wrote:
>>
>>>
>>>
>>> On Thu, 28 Apr 2011, Eduardo Felipe wrote:
>>>
>>>> I would appreciate if I'm mentioned as the author of the patch and the
>>>> commit message is preserved.
>>>> This is the third time a patch of mine is accepted without
>>>> attribution, and I think it shows a lack of care for input from users.
>>>
>>> what I can do is added a CahngeLog entry mentioning you as the author.
>>> Would it be sufficient ?
>>
>> or I can revert it and re-commit it with what you want
>>
>>>
>>> Vincent
>>>
>>>
>>>>
>>>> Eduardo.
>>>>
>>>> On Thu, Apr 28, 2011 at 3:43 PM, Vincent Torri <vt...@un...>
>>>> wrote:
>>>>>
>>>>>
>>>>> On Thu, 28 Apr 2011, Eduardo Felipe wrote:
>>>>>
>>>>>> Folks,
>>>>>>
>>>>>> Mac OS X does not provide an implementation of clock_gettime() even
>>>>>> though it's POSIX, but it does provide a fast high-resolution
>>>>>> monotonic clock through mach specific APIs that are perfectly suited
>>>>>> for usage in ecore_timer.
>>>>>>
>>>>>> Without this patch ecore_timer throws a critical warning on Mac OS X.
>>>>>
>>>>> in svn, thanks
>>>>>
>>>>> Vincent
>>>>>
>>>>
>>>>
>>>
>>
>
>