Re: [E-devel] E SVN: davemds trunk/ecore/src/lib/ecore_con

[Raphael K. da C. <ku...@pr...>]

David Seikel <on...@gm...> writes:

> On Mon, 31 Jan 2011 17:00:21 -0200 Raphael Kubo da Costa
> <ku...@pr...> wrote:
>
>> "Enlightenment SVN" <no-...@en...> writes:
>> 
>> > Log:
>> >  :/   setting a const char * param to NULL ?? and after the
>> > return ?? :O random spank
>> >
>> > Author:       davemds
>> > Date:         2011-01-31 10:48:50 -0800 (Mon, 31 Jan 2011)
>> > New Revision: 56611
>> > Trac:         http://trac.enlightenment.org/e/changeset/56611
>> >
>> > Modified:
>> >   trunk/ecore/src/lib/ecore_con/ecore_con_url.c 
>> >
>> > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c
>> > ===================================================================
>> > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c	2011-01-31
>> > 17:29:24 UTC (rev 56610) +++
>> > trunk/ecore/src/lib/ecore_con/ecore_con_url.c	2011-01-31
>> > 18:48:50 UTC (rev 56611) @@ -321,7 +321,6 @@ return url_con;
>> >  #else
>> >     return NULL;
>> > -   url = NULL;
>> >  #endif
>> >  }
>> 
>> If we enter the #else, we need to use the `url' parameter, otherwise
>> the compiler will complain about unused parameters.
>
> The compiler is not bitching about unreachable code?

I've never compiled this code without libcurl, so I don't know. If it
does,

  (void)url;
  return NULL;

might be more appropriate.

-- 
Raphael Kubo da Costa
ProFUSION embedded systems
http://profusion.mobi