Re: [E-devel] [PATCH] epoll support for ecore (v2)

[Gustavo S. B. <bar...@pr...>]

On Mon, May 17, 2010 at 11:40 PM, Mike McCormack
<mj....@sa...> wrote:
> Hi All,
>
> Here's a second version of my patch, updated for various comments.
>
> It seems to pass the regression tests, and E still starts up.
>
> This version has lots more #ifdefs (sorry Vincent), to address Gustavo's
> comment that the #ifdefs should be inside functions, not outside them.
> I think this makes things more messy, but I'm the newcomer round here... :-)
>
> Secondly, I haven't tested GTK integration, but it should work with this
> version of the patch, as the epoll fd itself is passed to
> main_loop_select().
>
> Adding a shutdown call to close the epoll_fd is trivial, and I'll do this
> after
> further testing and further comments...

looks good to me.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: bar...@gm...
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202