Re: [E-devel] border swallow vs. rect

[Carsten H. (T. R. <ra...@ra...>]

On Wed, 23 Dec 2009 10:24:40 -0500 Christopher Michael <cpm...@co...>
said:

> Hi devs,
> 
> While searching for a way to add an e_border to an e_box, I discovered 
> something that seemed odd to me and I am wondering if we are making 
> borders "heavier" than they need to be ? Let me explain....
> 
> In the theme edc for borders, we have "e.swallow.client" as a type: 
> SWALLOW. I presumed this was meant so that the border can swallow the 
> client window, but after digging into the code, I discovered that we 
> never actually swallow anything into that part. The "e.swallow.client" 
> part is only used (as far as I can tell) to get the geometry for the 
> actual client window via edje_object_part_geometry_get. We then set the 
> netwm & e frame_size based on the return geometry there so that the 
> client "lines up" with the border...We never actually swallow anything 
> into it.
> 
> So my question is, could we get by with a lighter RECT there ? I tested 
> it here by making the change in the theme, and there were no adverse 
> effects apparent....
> 
> Perhaps someone can explain why we used a SWALLOW there instead of a 
> RECT ? Wouldn't using a RECT be a bit lighter ?

because.. in the future... i do want to swallow clients into edje parents. so
may as well do that now :0 swallow also isnt really  much heavier than a rect :)

-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ra...@ra...