Re: [E-devel] E SVN: andreas branches/edje_editor_elm/src/bin

[Andreas V. <li...@br...>]

Am Wed, 28 Oct 2009 02:17:52 +0100 schrieb Dave Andreoli:

Hello Dave,

> Thanks for your work! I'm really happy that someone contribute :)
> 
> Just some comments:
> 
> In the function program_source_combo_populate(void):
>  * Use elm_hoversel_clear() instead of looping and delete.
>  * Use EINA_LIST_FOREACH() instead of the while(l) loop. You can
> avoid ugly cast and save some line of code.

For 1) I did it. For 2) I added a TODO until I have time for it. Thanks
for the hint.

> ...and a personal style preference ;)
> instead of:
> 
> // Set source
> s = edje_edit_program_source_get (ui.edje_o, cur.prog);
> if (!s)
> {
>     elm_hoversel_label_set(_source_combo, "none"); // TODO: minimal
> width }
> else
> {
>    elm_hoversel_label_set(_source_combo, s);
> }
> 
> you can use:
> // Set source
> s = edje_edit_program_source_get (ui.edje_o, cur.prog);
> elm_hoversel_label_set(_source_combo, s ? s : "none");

Good idea. I've done it.

I just added some more fixed. I liked the old editor before and it
should get fast at least the same features.

I don't like the widget macros. I moved them in the first step to
edje_editor_widgets.h. But in the next step I would replace the macros
by custom widget functions.

I tried to work with spinners, but the result was bad. I think some
work in Elementary needs to be done before.

regards
  Andreas