Re: [E-devel] [PATCH] mouse wheel support for the illume keyboard

[Dima K. <dk...@cd...>]

Hi Raster.

I'm not quite as careless as you seem to think. The X patch allows for
both dragging and mousewheel scrolling, depending on the dynamics of
the motion (for details, see the post linked in the original email
below). Dragging, using drawing apps, etc, are still possible. In the
current implementation, mousewheel scrolling is easier to trigger, so
anybody who uses a lot of apps with dragging motions would get mildly
annoyed. As such, I don't consider the X patch ready to go upstream
yet; there really needs to be a switch to disable the new behavior.

The purpose for this patch is to add finger-scrolling support for
a huge number of applications already out there. I can now scroll my
browser without needing to aim for the scrollbar. If you ask me,
implementing the scrolling-as-dragging behavior on the application
level is silly, and really belongs in the mouse driver. In either case,
the patch to the illume keyboard is fairly innocuous. I don't think
anybody who has a real wheel-mouse attached to their device is likely
to be using a soft keyboard. Thoughts?

dima

On Fri, 4 Sep 2009 10:57:44 +1000
Carsten Haitzler (The Rasterman) <ra...@ra...> wrote:

> On Fri, 10 Jul 2009 09:12:44 -0700 Dima Kogan
> <dk...@cd...> said:
> 
> > Hi.
> > 
> > I added support for touchscreen scrolling to kdrive and tslib-based
> > X servers. With that patch, screen dragging can generate mousewheel
> > events instead of dragging events. This behavior directly conflicts
> > with those parts of e that try to implement that
> > dragging-as-scrolling functionality in the application instead of
> > in the driver. I'm attaching a patch to support mouse-wheel events
> > in the illume keyboard. For the patch to the xserver (haven't sent
> > it upstream yet), see
> > 
> > http://lists.shr-project.org/pipermail/shr-devel/2009-July/000251.html
> > 
> > The new behavior is working very well for me, and I think this patch
> > should be included in the tree.
> 
> hmm. such a x patch will conflict with every app that:
> 
> 1. scrolls with a scrollbar
> 2. scrolls by dragging content
> 3. has a slider of some sort
> 4. drawing apps
> 5. handwriting recognition
> 6. games that use any dragging
> 7. drag and drop
> 
> if you ask me... thats a pretty bad idea. it may work for the illume
> kbd, but a tonne of elementary, e itself and other apps and toolkits
> are broken now. why did you do this? it's a bit like throwing a
> nuclear bomb on your city to kill the cockroach under your fridge. :)
> 
> -- 
> ------------- Codito, ergo sum - "I code, therefore I am"
> -------------- The Rasterman (Carsten Haitzler)
> ra...@ra...