[E-devel] Sugested patch for Elementary

[Thiago <bo...@gm...>]

Hi guys,

I'm currently working on an IM client plugin for Canola in GSoC. This is my
first proposed patch for enlightenment.

The problem begun when I tried to embed a elm widget inside canola. Every
time I created a widget, with a Edje smart object as parent, I got
segfaults. So I started investigating why it happaned inside the binding.
Nothing was wrong with it. Then I looked inside the code for elementary.
There I found it. All widgets suppose their top father is an evas smart
object containing a Elm_Win structure as the data field. Thats not true in
my case. So the patch changes the function elm_win_xwindow_get() inside
elm_win.c in a way that it get the xwindow reference from the evas of the
object, avoiding the corruption of data done by calling
_elm_win_xwindow_get(). See code for more details. That fixed the first
problem.

But I kept getting segfaults when I used an entry widget, after I gave it
the focus. Problem was _on_focus_hook() (elm_entry.c) calling
elm_win_keyboard_mode_set(). This would also currupt a non-Elm_Win structure
pointed by data. So I proposed the creation of a magic field inside Elm_Win
to be tested before doing any operations that needs the smart object to be
attached to Elm_Win.

The patch is working with tests and everything is working for me! I don't
know if this is the best solution, but at least it is one.

Waiting on comments!

Thanks.

-- 
Thiago 'bolaum' Borges Abdnur
----------------------------------
"Trust no one..."
- Deep Throat (The X-Files)