Re: [E-devel] [PATCH/RFC] e_fm2 avoid invalid mouse-up

[Gustavo S. B. <bar...@pr...>]

On Wed, Jun 10, 2009 at 5:21 AM, "Marco Trevisan
(Treviño)"<ma...@3v...> wrote:
> Gustavo Sverzut Barbieri wrote:
>> Again it looks good, just a minor indentation issue with:
>>
>> +     ed = evas_event;
>>
>> (ed is off).
>
> Oh, ok sorry. I'm not so familiar with the E's indentation rules :P
> They seems so strange... :)
>
>> as for just emit click if release (up) was on the given object, it
>> should be like that. At least that's how edje does it for "click".
>
> I figured that, since this issue generally doesn't happen; but there are
> some exceptions (quite frequent, BTW) which needed this workaround.
>
>> about evas_smart and on_hold flag, I'm not really doing that these
>> days and no time to look at it now, maybe raster can comment on it
>> later.
>
> Ok, I'll wait him ;)

In svn (your last patch). If you change your mind about on_hold and
other stuff, send incremental patches now.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: bar...@gm...
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202