Re: [E-devel] patch for desk flip animation modules

[<han...@gm...>]

On Sat, May 9, 2009 at 12:21 AM, Viktor Kojouharov
<vko...@gm...> wrote:
> On Fri, 2009-05-08 at 23:44 +0200, han...@gm... wrote:
>> On Fri, May 8, 2009 at 11:23 PM, han...@gm...
>> <han...@go...> wrote:
>> > Hello everyone,
>> > attached is a patch that allows to have additional deskflip animations
>> > registered by modules. Could someone please review it? Suggestions are
>> > welcome :)
>
> some comments from a quick glance:
>
> line 130: why not the E_NEW macro rather than calloc?
>
yup. changed to E_NEW. wondering why calloc is still used in so many
places though

> line 261: Answer to the XXX - it is nice to know when a desk has
> finished flipping. And the zone uses it to know when the flip animation
> is over. When there is no animation, it is fired immediately.
>
I see. I've also added the function e_desk_anim_finished with a
comment that animation plugins should call this method.

> Also, with more animations, that settings dialog can quickly go out of
> hand. Maybe you should rearrange the whole dialog to use
> e_widget_toolbook, and place the animation options in a tab. Also, maybe
> the animation struct should also (optionally?) provide an evas object
> that can display a preview of the animation itself, so that user know
> what they are selecting.
>
Good ideas. I've tried to make a toolbook from the advanced dialog
though the deskpreview widget does not hide as it should. I could make
an ilist of the animation items if that is wanted. The animation
preview should be easy to add later on but it seems quite a lot of
work to write it. you know, this patch is intended to be able to get
rid of ecomorph-e17 in the first place :)

update: http://pastie.org/private/omyz23rdfhmohjwlzhnd8w

>
>> >
>> > Best Regards,
>> > Hannes
>> >
>>
>> update: removed printf and added a comment
>> http://pastie.org/private/alfndwnkuqtsefyc9olpg
>>
>> ------------------------------------------------------------------------------
>> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
>> production scanning environment may not be a perfect world - but thanks to
>> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
>> Series Scanner you'll get full speed at 300 dpi even with all image
>> processing features enabled. http://p.sf.net/sfu/kodak-com
>> _______________________________________________
>> enlightenment-devel mailing list
>> enl...@li...
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>