From: carlo\.bramix <car...@li...> - 2008-11-01 11:56:16
|
Hello, I tried to analize my changes more in detail. The mmap() problem with TGA file loader: I could do it natively on Windows too (with CreateFileMapping(), MapViewOfFile(), etc) but I do not think this is what you really want... So, this is a good reason for adding the dependency with Evil if mmap() is supported. As alternative, we can do a simple wrapper to another specific library like LibTGA, which just handle TGA images as you can probably imagine by its name. BTW, I improved libTGA a lot because I wanted to use it in my Windows image viewer clone, but it seems I received no replies from the author... (sigh!). LibJPEG is normally used with setjmp/longjmp under Windows. I admit that I do not know if this will corrupt something with IMLIB2. Into IMLIB2 there are already some #ifdef on EMX. The coding solution for EMX is good for Windows too. There is only one wrong thing here and it is the inclusion of pwd.h which do not exists under Windows. So I simply added the check on pwd.h into configure script. The "-no-undefined" flag is required for mingw and cygwin, otherwise libtool will never create a shared library. There are no much work-arounds here. I added macro IMLIB2_IS_COMPILING to distinguish the compilation of IMLIB2 from the applications. There was already BUILDING_DLL with a similar purpose, but if a library depends from IMLIB2 and it uses BUILDING_DLL too, it will happen an error because an import/export confict (I already encountered such problems in the past). If I can give a suggestion, I would use a different name here. Some functions are missing, (mkstemp, dlopen, etc) but doing a replacement is very easy even for me ;) For the functions into dlfcn.h, it would be perfect to use dlfcn-win32 package but since it is not compiled with libtool (in other words, there is no libdl.la file) the linking fails to build a shared library because it cannot know the dependencies of "-ldl" (perhaps a fix to dlfcn-win32 will be appreciated). In conclusion, these functions too may be provided by Evil. I hope this will help. Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : "Vincent Torri" vt...@un... To : "Kim Woelders" ki...@wo... Cc : "enlightenment-devel" enl...@li... Date : Sat, 1 Nov 2008 08:23:50 +0100 (CET) Subject : Re: [E-devel] IMLIB2 ported to mingw+msys > On Thu, 30 Oct 2008, Kim Woelders wrote: > > > On Tue, 28 Oct 2008 17:45:10 +0100, carlo.bramix <car...@li...> > > wrote: > > > >> Hello, > >> I got the sources of your newly released Imlib2 1.4.2 and I did again the > >> fixes for Mingw+Msys. > >> I think I also fixed my bugs with: > >> 1) bad mmap() detection > >> 2) wrong use of HAVE_SIGJMP_BUF instead of HAVE_SIGSETJMP. > >> 3) all my files are in unix format. > >> I tested Imlib2 with: > >> - Mingw+Msys > >> - Cygwin > >> - Linux Debian 4.0r3 > >> and everything seems to be working. > >> Attached patch includes all those fixes. > >> > > > > dlfcn-win32.c/h are missing from this patch. I assume they were meant to the > > same as in the original patch. > > > > Vincent - Do you still want to evilify imlib2? Otherwise I'm fine with this > > patch (except a few nitpicks I'll fix if/when committed). > > I can try to integrate Evil. Right now, i'm trying to make the efl working > natively on Windows CE. If you can wait a bit (around 1 week), I'll try to > do it next week end > > Vincent > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |