From: Carsten H. (T. R. <ra...@ra...> - 2008-09-02 23:29:36
|
On Tue, 2 Sep 2008 22:16:50 +0200 (CEST) Dave Andreoli <da...@gu...> babbled: > > ----- "Cedric BAIL" <ced...@fr...> ha scritto: > > > On Thu, Aug 21, 2008 at 3:47 PM, Joerg Sonnenberger > > <jo...@br...> wrote: > > > On Thu, Aug 21, 2008 at 11:38:32AM +0200, Cedric BAIL wrote: > > >> Ok, just testing it and reviewing it. Could you tell me why you > > did > > >> change this code, doesn't look like it's related to the other > > change. > > > > > > I have no idea where that change comes from. I suspect some merge > > > failure from cvs. > > > > > >> > Do you get timeouts from the test-suite as well? > > >> > > >> We have currently to test that fail : > > >> Eet Data Encoding/Decoding:eet_test_data_type_dump_undump > > >> Eet File:eet_file_data_dump_test > > >> > > >> due to a bug related to the handle of EET_G_UNKNOWN in > > >> _eet_data_dump_encode. But other test should work just fine. > > >> > > >> I did just run the tests with the new patch, and I am still > > >> experiencing failure : > > >> > > >> eet_suite.c:947:F:Eet Image:eet_image:0: Failure 'result == 0' > > occured > > >> eet_suite.c:1161:F:Eet Image:eet_small_image:0: Failure 'data[0] != > > IM0' occured > > > > > > I get a timeout for this test as well. Which is why I ask. > > > > Ok, I fixed your patch and commited it. It should work fine, but if > > not please report any failure regarding eet and compressed image to > > me. > > Hi... some work for you :P > > The editor cannot import jpg images anymore, in my tests > edje_cc segv when you use a jpg image and set it LOSSY. > > You can try any edc that use jpg with LOSSY like this: > -------------------------------------------------------- > images { > image: "mem.jpg" LOSSY 90; > } > collections { > group { > name: "icon"; > parts { > part { > name: "image"; > type: IMAGE; > description { > state: "default" 0.00; > image { > normal: "mem.jpg"; > } > } > } > } > } > } > -------------------------------------------------------- > This is the simplest test case I can provide. It segv when you compile it, > break in eet_image.c on line 705 > > > The editor in fact import all the images as LOSSY 100, and now > segv when loading jpg. I have tested with previous revision and works well. > > Let me know if you need more info ;) > > Dave just tried: images { image: "vgrad_dark.png" COMP; /* the encoding method is "COMP". this * is lossless, but compressed */ image: "grill_dark_tiny_pattern.png" LOSSY 90; ... no segv. :/ -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ra...@ra... |