From: Toma <tom...@gm...> - 2008-07-08 00:04:36
|
I agree with you KainX. It is a bit of a mess. The application the theme generally themes is put in the name or filename of it. And yes, lets stick to KISS to begin with and then go from there. If a definite need to have those other things is found, then I guess it can be adopted, but I cant see that happening. Viktor: Im not too sure on that one. EWL has some of these components in the theme already and they start with /theme, but I wasnt sure if /theme/ and theme/ were the same thing. Otherwise, definitely scrap the leading /. Toma 2008/7/8 Viktor Kojouharov <vko...@gm...>: > Since the current naming practice for edje parts is to start with a > letter, instead of '/', wouldn't it be better to keep it here: > > item: "theme/application/e/version" "xxx" > > On Mon, 2008-07-07 at 14:23 +0200, Dave Andreoli wrote: >> ----- "Toma" <tom...@gm...> ha scritto: >> >> > So change /theme/base_version to /theme/application_version too? >> > Sounds fun. What about themes that contain multiple themes packs? Eg. >> > detour? Or the new idea of combining e17 themes with etk and ewl >> > components installed? Would items with the same name be overwritten >> > by >> > the last one loaded? Or just load them with "e etk ewl" in the same >> > space... >> >> hmmm, this is a problem... we can use: >> item: "/theme/applications" "e etk ewl"; >> >> but then we also need multiple "application_version" fiels, like: >> item: "/theme/e_version" "xxx" >> item: "/theme/etk_version" "xxx" >> item: "/theme/ewl_version" "xxx" >> >> Dave >> >> >> >> > Toma >> > >> > 2008/7/7 Dave Andreoli <da...@gu...>: >> > > >> > > ----- "Toma" <tom...@gm...> ha scritto: >> > > >> > >> Ok folks! Heres a final revision. Note the removal of e/ so that >> > it >> > >> can be universally used without the need to figure out the leading >> > >> name (if there are any). Also included is 'base_version' to >> > outline >> > >> the base version of the application needed to use the theme. >> > Again, >> > >> its a non-specific name so it can be used universally too. If >> > there >> > >> are no objections, Ill start stuffing this into my themes and hope >> > >> that it gets picked up by everyone else soon enough. >> > >> >> > >> data { >> > >> item: "/theme/name" "Fireball"; >> > >> item: "/theme/version" "1.6"; >> > >> item: "/theme/license" "GPL"; >> > >> item: "/theme/author" "Tom Haste (tom...@gm...)"; >> > >> item: "/theme/base_version" "CVS"; >> > >> } >> > > >> > > IMHO I would add a fileld with the name of the application the theme >> > is for. >> > > like >> > > item: "/theme/application" "e"; >> > > item: "/theme/application" "etk"; >> > > item: "/theme/application" "edje_editor"; >> > > >> > > Or you will have to read all the contents everytime just to check if >> > the >> > > theme is right for you. >> > > Also applications that want to make a check on the theme, will just >> > have >> > > to read at this fields instead of reading all of the parts list. >> > > >> > > Dave >> > > >> > >> >> > >> Toma. >> > >> >> > >> Also... CVS can be swapped with '16.999.043' for people that wish >> > to >> > >> stay with the snapshots or the folks in elive can name it >> > >> accordingly. >> > >> >> > >> 2008/7/2 Dale Anderson <da...@st...>: >> > >> > Toma wrote: >> > >> >> >> > >> >> Heres what Ive just spent the last 30 mins doing... >> > >> >> >> > >> >> data { >> > >> >> item: "e/theme/name" "Fireball"; >> > >> >> item: "e/theme/version" "1.6"; >> > >> >> item: "e/theme/license" "GPL"; >> > >> >> item: "e/theme/author" "Tom Haste >> > (tom...@gm...)"; >> > >> >> } >> > >> >> >> > >> >> --------------- >> > >> >> >> > >> >> data { >> > >> >> item: "etk/theme/name" "Fireball-ETK"; >> > >> >> item: "etk/theme/version" "1.1"; >> > >> >> item: "etk/theme/license" "GPL"; >> > >> >> item: "e/theme/author" "Tom Haste >> > (tom...@gm...)"; >> > >> >> } >> > >> >> >> > >> >> ----------------- >> > >> >> >> > >> >> data { >> > >> >> item: "/theme/name" "Fireball-EWL"; >> > >> >> item: "/theme/version" "1.2"; >> > >> >> item: "/theme/license" "CC License: >> > >> >> http://creativecommons.org/licenses/by-sa/2.5"; >> > >> >> item: "/theme/author" "Tom Haste (tom...@gm...) & >> > dj2 >> > >> >> (www.everburning.com)"; >> > >> >> item: "/theme/font_path" "fonts"; >> > >> >> } >> > >> >> >> > >> >> ------------------- >> > >> >> >> > >> >> data { >> > >> >> item: "/theme/name" "Fireball-Entrance"; >> > >> >> item: "/theme/version" "1.1"; >> > >> >> item: "/theme/license" "GPL"; >> > >> >> item: "/theme/author" "Tom Haste >> > (tom...@gm...)"; >> > >> >> } >> > >> >> >> > >> >> -------------------- >> > >> >> >> > >> >> As you can see, the version string is for the theme itself. The >> > >> naming >> > >> >> I tried to stick to what its actually themeing and in the case >> > of >> > >> EWL, >> > >> >> I just went with what was already there. Entrance on the other >> > >> hand, >> > >> >> is a bit of a mess in terms of group names so I just went with >> > >> >> /theme/blah. >> > >> >> >> > >> >> Providing a 'Works with this version' tag is a pain. Im not >> > going >> > >> to >> > >> >> make themes for different snapshots and CVS. There is only 1 >> > >> "version" >> > >> >> IMHO and thats CVS. Much like how I dont put version numbers >> > in >> > >> >> filenames, I dont want people building up a directory of old >> > and >> > >> >> broken themes. When one of my themes break (due to CVS changes) >> > I >> > >> >> promptly release and update and thats it. >> > >> >> >> > >> > >> > >> > Thats all very well and fine while e17 is still *in development* >> > , >> > >> but when >> > >> > there are releases we need to be able to cater for such down the >> > >> track. >> > >> > Themer's are going to have to take this into account also in the >> > >> future. >> > >> > >> > >> > Cheers >> > >> > Dale. >> > >> > >> > >> >> Im going to spend the next week or so polishing up everything >> > and >> > >> >> revising code and to let this idea sink in. >> > >> >> Toma >> > >> >> >> > >> >> >> > >> >> 2008/7/1 Sthithaprajna Garapaty <iam...@gm...>: >> > >> >> >> > >> >>> >> > >> >>> I like this idea a lot. It would be good to make those fields >> > >> >>> mandatory, and hide >> > >> >>> themes from the theme configuration dialog if they dont have >> > all >> > >> of >> > >> >>> those fields. >> > >> >>> That would really speed up adoption. >> > >> >>> >> > >> >>> Beyond the e/theme/version (which matches the version of E), I >> > >> would >> > >> >>> suggest >> > >> >>> adding a version for the theme itself. This would make it easy >> > to >> > >> do >> > >> >>> automatic >> > >> >>> updates on themes. Seems like Toma suggested this, and then >> > forgot >> > >> about >> > >> >>> it. >> > >> >>> >> > >> >>> Maybe something like >> > >> >>> item: "e/theme/theme-version" "1.0"; >> > >> >>> >> > >> >>> On Tue, Jul 1, 2008 at 11:08 AM, Sthithaprajna Garapaty >> > >> >>> <iam...@gm...> wrote: >> > >> >>> >> > >> >>>> >> > >> >>>> I like this idea a lot. It would be good to make those fields >> > >> >>>> mandatory, and hide >> > >> >>>> themes from the theme configuration dialog if they dont have >> > all >> > >> of >> > >> >>>> those fields. >> > >> >>>> That would really speed up adoption. >> > >> >>>> >> > >> >>>> Beyond the e/theme/version (which matches the version of E), >> > I >> > >> would >> > >> >>>> suggest >> > >> >>>> adding a version for the theme itself. This would make it easy >> > to >> > >> do >> > >> >>>> automatic >> > >> >>>> updates on themes. Seems like Toma suggested this, and then >> > >> forgot about >> > >> >>>> it. >> > >> >>>> >> > >> >>>> Maybe something like >> > >> >>>> item: "e/theme/theme-version" "1.0"; >> > >> >>>> >> > >> >>>> >> > >> >>>> >> > >> >>>> On Tue, Jul 1, 2008 at 4:28 AM, The Rasterman Carsten >> > Haitzler >> > >> >>>> <ra...@ra...> wrote: >> > >> >>>> >> > >> >>>>> >> > >> >>>>> On Mon, 30 Jun 2008 15:23:32 +0200 Brian 'morlenxus' Miculcy >> > >> >>>>> <mor...@gm...> babbled: >> > >> >>>>> >> > >> >>>>> I think adding these in is a good idea. namespacing sounds >> > good. >> > >> those >> > >> >>>>> seem >> > >> >>>>> important fields - useful. as brian said - the rest is >> > implicit >> > >> in the >> > >> >>>>> .edj >> > >> >>>>> file contents itself and is simply a matter of making the >> > theme >> > >> chooser >> > >> >>>>> better >> > >> >>>>> (being able to open and inspect the .edj file - list all the >> > >> groups and >> > >> >>>>> from >> > >> >>>>> that make an assessment if its a full or partial theme - or >> > just >> > >> a >> > >> >>>>> wallpaper, >> > >> >>>>> and which bit of e does it try and theme, and how much). the >> > >> theme >> > >> >>>>> preview >> > >> >>>>> still needs to fake up window borders, windows, menus, >> > dialogs >> > >> etc. not >> > >> >>>>> just >> > >> >>>>> the wallpaper, so when you select a theme you get a preview >> > >> that >> > >> >>>>> somewhat >> > >> >>>>> resembles what you will get. >> > >> >>>>> >> > >> >>>>> >> > >> >>>>>> >> > >> >>>>>> I like the idea. The four items you selected are a good >> > >> selection. We >> > >> >>>>>> don't need a description what a theme file themes - because >> > the >> > >> edje >> > >> >>>>>> file >> > >> >>>>>> itself descripes it. You can get the group parts from the >> > file >> > >> and so >> > >> >>>>>> it's >> > >> >>>>>> possible to show in a dialog what an edje file exactly >> > does. >> > >> >>>>>> We also need a better theme dialog as we get more and more >> > edje >> > >> files >> > >> >>>>>> which only theme a few parts, for example border themes or >> > >> themes for >> > >> >>>>>> specific modules. The import button only allows to import >> > full >> > >> themes, >> > >> >>>>>> also i think it's somehow confusing to be able to set a >> > >> background or >> > >> >>>>>> init theme from the advanced theme dialog and also from the >> > >> init / >> > >> >>>>>> wallpaper dialog. We need to reorganise that. >> > >> >>>>>> >> > >> >>>>>> Greets, >> > >> >>>>>> Brian 'morlenxus' Miculcy >> > >> >>>>>> >> > >> >>>>>> On Mon, Jun 30, 2008 at 09:10:03PM +0800, Toma wrote: >> > >> >>>>>> >> > >> >>>>>>> >> > >> >>>>>>> I would say this about covers most of the necessary >> > >> information. >> > >> >>>>>>> >> > >> >>>>>>> data { >> > >> >>>>>>> item: "e/theme/name" "BlingBling"; >> > >> >>>>>>> item: "e/theme/version" "16.999.043"; >> > >> >>>>>>> item: "e/theme/license" "3-Clause BSD"; >> > >> >>>>>>> item: "e/theme/author" "Carsten Rasterman Haitzler & >> > the >> > >> E17 >> > >> >>>>>>> Team"; } >> > >> >>>>>>> >> > >> >>>>>>> The 'about' block in the About_Theme could simply state >> > all >> > >> these >> > >> >>>>>>> things again or just totally leave out the 'about' >> > textblock >> > >> all >> > >> >>>>>>> together. >> > >> >>>>>>> >> > >> >>>>>>> Im wondering if 'item: "theme/usage" "e17"' would be >> > useful >> > >> aswell, >> > >> >>>>>>> as >> > >> >>>>>>> its difficult to tell by simply looking at an edje what >> > the >> > >> file is >> > >> >>>>>>> meant to theme, unless the author has made it bleeding >> > >> obvious. >> > >> >>>>>>> Toma >> > >> >>>>>>> >> > >> >>>>>>> 2008/6/30 Toma <tom...@gm...>: >> > >> >>>>>>> >> > >> >>>>>>>> >> > >> >>>>>>>> Hmm good call. There are a few more levels you could take >> > >> aswell, >> > >> >>>>>>>> eg. >> > >> >>>>>>>> License, Author... its just a matter of whats really >> > needed. >> > >> But >> > >> >>>>>>>> thanks for edje and eet, its all details that can be >> > stored >> > >> in the >> > >> >>>>>>>> files, and we should really take advantage of that. >> > >> >>>>>>>> Toma >> > >> >>>>>>>> >> > >> >>>>>>>> 2008/6/30 Nick Hughart <me...@me...>: >> > >> >>>>>>>> >> > >> >>>>>>>>> >> > >> >>>>>>>>> I'd even go a bit further and possibly add something like >> > a >> > >> minimum >> > >> >>>>>>>>> E >> > >> >>>>>>>>> version required for the theme. There may even be other >> > >> details >> > >> >>>>>>>>> that >> > >> >>>>>>>>> could be useful. Question is, will anyone else think >> > it's a >> > >> good >> > >> >>>>>>>>> idea :) >> > >> >>>>>>>>> >> > >> >>>>>>>> >> > >> >>>>>>>> Hmm good call. There are a few more levels you could take >> > >> aswell, >> > >> >>>>>>>> eg. >> > >> >>>>>>>> License, Author... its just a matter of whats really >> > needed. >> > >> But >> > >> >>>>>>>> thanks for edje and eet, its all details that can be >> > stored >> > >> in the >> > >> >>>>>>>> files, and we should really take advantage of that. >> > >> >>>>>>>> Toma >> > >> >>>>>>>> >> > >> >>>>>>>> >> > >> >>>>>>>>> >> > >> >>>>>>>>> Toma wrote: >> > >> >>>>>>>>> >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> Hey all! >> > >> >>>>>>>>>> I think it would be really great to have a theme name >> > and >> > >> version >> > >> >>>>>>>>>> locked in an edj for purpose of identification. Until >> > now >> > >> the >> > >> >>>>>>>>>> theme >> > >> >>>>>>>>>> name and version is stored in the filename which is a >> > very >> > >> flakey >> > >> >>>>>>>>>> and >> > >> >>>>>>>>>> sometimes misleading way to store this. I think it would >> > be >> > >> a good >> > >> >>>>>>>>>> idea to start using what EWL does but extend it >> > slightly >> > >> and >> > >> >>>>>>>>>> include >> > >> >>>>>>>>>> the themes Name and Version in the actual edje data{} >> > >> itself. >> > >> >>>>>>>>>> Heres an >> > >> >>>>>>>>>> example. >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> data { >> > >> >>>>>>>>>> item: "e/theme/name" "ThemeName"; >> > >> >>>>>>>>>> item: "e/theme/version" "2.0"; >> > >> >>>>>>>>>> } >> > >> >>>>>>>>>> collections{} >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> That way the themes details can be parsed and possibly >> > >> implemented >> > >> >>>>>>>>>> into the E theme selector itself. What should be >> > discussed >> > >> is the >> > >> >>>>>>>>>> naming. Is "e/theme/name" ok? I know in ewl its >> > >> "/theme/name" but >> > >> >>>>>>>>>> Im >> > >> >>>>>>>>>> not sure if that could/should be carried over to E. >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> >> > >> >> > ------------------------------------------------------------------------- >> > >> >>>>>>>>>> Check out the new SourceForge.net Marketplace. >> > >> >>>>>>>>>> It's the best place to buy or sell services for >> > >> >>>>>>>>>> just about anything Open Source. >> > >> >>>>>>>>>> http://sourceforge.net/services/buy/index.php >> > >> >>>>>>>>>> _______________________________________________ >> > >> >>>>>>>>>> enlightenment-devel mailing list >> > >> >>>>>>>>>> enl...@li... >> > >> >>>>>>>>>> >> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >>>>>>>>>> >> > >> >>>>>>>>>> >> > >> >>>>>>>>> >> > >> >>>>>>>>> >> > >> >>>>>>> >> > >> >>>>>>> >> > >> >>>>>>> >> > >> >> > ------------------------------------------------------------------------- >> > >> >>>>>>> Check out the new SourceForge.net Marketplace. >> > >> >>>>>>> It's the best place to buy or sell services for >> > >> >>>>>>> just about anything Open Source. >> > >> >>>>>>> http://sourceforge.net/services/buy/index.php >> > >> >>>>>>> _______________________________________________ >> > >> >>>>>>> enlightenment-devel mailing list >> > >> >>>>>>> enl...@li... >> > >> >>>>>>> >> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >>>>>>> >> > >> >>>>>> >> > >> >>>>>> >> > >> >>>>>> >> > >> >> > ------------------------------------------------------------------------- >> > >> >>>>>> Check out the new SourceForge.net Marketplace. >> > >> >>>>>> It's the best place to buy or sell services for >> > >> >>>>>> just about anything Open Source. >> > >> >>>>>> http://sourceforge.net/services/buy/index.php >> > >> >>>>>> _______________________________________________ >> > >> >>>>>> enlightenment-devel mailing list >> > >> >>>>>> enl...@li... >> > >> >>>>>> >> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >>>>>> >> > >> >>>>>> >> > >> >>>>> >> > >> >>>>> -- >> > >> >>>>> ------------- Codito, ergo sum - "I code, therefore I am" >> > >> >>>>> -------------- >> > >> >>>>> The Rasterman (Carsten Haitzler) ra...@ra... >> > >> >>>>> >> > >> >>>>> >> > >> >>>>> >> > >> >>>>> >> > >> >> > ------------------------------------------------------------------------- >> > >> >>>>> Check out the new SourceForge.net Marketplace. >> > >> >>>>> It's the best place to buy or sell services for >> > >> >>>>> just about anything Open Source. >> > >> >>>>> http://sourceforge.net/services/buy/index.php >> > >> >>>>> _______________________________________________ >> > >> >>>>> enlightenment-devel mailing list >> > >> >>>>> enl...@li... >> > >> >>>>> >> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >>>>> >> > >> >>>>> >> > >> >>> >> > >> >>> >> > >> >> > ------------------------------------------------------------------------- >> > >> >>> Check out the new SourceForge.net Marketplace. >> > >> >>> It's the best place to buy or sell services for >> > >> >>> just about anything Open Source. >> > >> >>> http://sourceforge.net/services/buy/index.php >> > >> >>> _______________________________________________ >> > >> >>> enlightenment-devel mailing list >> > >> >>> enl...@li... >> > >> >>> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >>> >> > >> >>> >> > >> >> >> > >> >> >> > >> >> > ------------------------------------------------------------------------- >> > >> >> Check out the new SourceForge.net Marketplace. >> > >> >> It's the best place to buy or sell services for >> > >> >> just about anything Open Source. >> > >> >> http://sourceforge.net/services/buy/index.php >> > >> >> _______________________________________________ >> > >> >> enlightenment-devel mailing list >> > >> >> enl...@li... >> > >> >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> >> > >> >> >> > >> > >> > >> > >> > >> >> > >> >> > ------------------------------------------------------------------------- >> > >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> > >> Studies have shown that voting for your favorite open source >> > project, >> > >> along with a healthy diet, reduces your potential for chronic >> > >> lameness >> > >> and boredom. Vote Now at >> > http://www.sourceforge.net/community/cca08 >> > >> _______________________________________________ >> > >> enlightenment-devel mailing list >> > >> enl...@li... >> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> _______________________________________________ >> enlightenment-devel mailing list >> enl...@li... >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > |