From: Tilman S. <ti...@co...> - 2007-12-03 22:41:07
|
Vincent Torri [2007-12-03 23:04]: >=20 >=20 > On Mon, 3 Dec 2007, Gustavo Sverzut Barbieri wrote: >=20 > > Hi guys, > > > > We found the root of those "unaligned loads", it was in canon.c > > (http://www.enlightenment.org/viewvc/e17/libs/epsilon/src/lib/exiftags/= canon.c?hideattic=3D1&r1=3D1.2&r2=3D1.3), > > with a patch tilman applied in order to reduce relocations due lots of > > strings requiring it at load time. > > > > The problem, according to a Red Hat gcc compiler engineer friend of > > mine, is that that construction is not valid according to 6.7.2.1/18 > > of C99-TC2 and GCC should not allow that, so it's both a bug with GCC > > and canon.c. > > > > canon.c could be fixed and still do few relocations by using one huge > > string with \0 as separators and place pointers to segments of this > > string on the struct. But it's a pain to do. > > > > So, I'd like to ask those who are using this exiftags support from > > Epsilon. I really don't think this should be in epsilon anyway... the > > only use of it in CVS is at esmart_thumb... and it's about > > orientation, which is a standard tag... So I request permission to > > remove all this exiftags stuff, if required I can add the code to find > > out orientation support and generate already rotated images later. > > This should make things a lot simpler, smaller and faster to start. > > > > comments? may I remove? >=20 > I have contacted tilman on irc. No answer from him yet, but if you can=20 > wait some hours, or a day, so that he can answer I don't use exiftags. Simply ripping out the code and throwing it away doens't sound right though. Regards, Tilman --=20 A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail? |