Re: [E-devel] E CVS: apps/e sebastid

[Holger H. <bar...@ar...>]

Sebastian Dransfeld <seb...@st...> writes:

> Holger Hanrath wrote:
> > Enlightenment CVS committal
> > 
> > Author  : sebastid
> > Project : e17
> > Module  : apps/e
> > 
> > Dir     : e17/apps/e/src/bin
> > 
> > 
> > Modified Files:
> > 	e_int_config_shelf.c e_shelf.c 
> > 
> > 
> > Log Message:
> > Always keep shelf list sorted on id.
> > 
> > <-- snip -->
> > 
> >  _cb_add(void *data, void *data2)
> >  {
> >     E_Config_Dialog_Data *cfdata;
> > -   Evas_List *shelves;
> > -   
> > -   cfdata = data;
> > -   while ((shelves = e_shelf_list()))
> > -     {
> > -	E_Shelf *es;
> > -	
> > -	es = shelves->data;
> > -	e_object_del(E_OBJECT(es));
> > -     }
> > -   ////
> > -     {
> > 
> > <-- snip -->
> > 
> >     
> > +   while (shelves)
> > +     {
> > +	E_Shelf *es;
> > +
> > +	es = shelves->data;
> > +	e_object_del(E_OBJECT(es));
> > +     }
> > +
> > 
> > must not shelves somehow be updated to exit the loop?
> 
> When a shelf is deleted it will remove itself from the shelves list.

sorry didn't see that shelves is global. :)

regards Holger