From: Nathan I. <nin...@gm...> - 2005-04-05 12:03:32
|
What you are seeing is remnants from when the list structure contained mutexes. The exposed API used to lock the structures and then pass them to the _ecore_list_* functions to do the actual work. Since the structures no longer contain mutexes, this could be reduced to single function calls. I have had some ideas for re-working the lists slightly, so I've been putting off the cleanup until I tested out some ideas. On Apr 5, 2005 4:03 AM, Piotr Skamruk <jel...@kn...> wrote: > * Piotr Skamruk, (jel...@kn...) napisa=B3: > > ... > later in code (: > 1. in ecore_list_nodes ret is initialized to some, but later it isn't use= d > (CHECK_ fail...) or is set to other value... > 2. in ecore_list_append declaration of ret is unnessesary, value returned > by _ecore_list_append_0 should be returned directly > 3. ecore_list_(insert|goto|current|remove|next|for_each), same as in 2. > 4. _ecore_list_remove_(0|first|last), same as in 1. > 5. ecore_list_goto_(index|first|last), same as in 2. > 6. in ecore_dlist_insert: > if (!ret) { > return ret; > } > better would be: > if (!ret) return NULL; > 7. ecore_dlist_(remove|goto|current|next|previous), same as in 2. > 8. same in ecore_dlist_goto_(index|first|last) > 9. same in ecore_dlist_remove_last > 10. _ecore_dlist_previous, same as in 1. >=20 > something else? :) >=20 >=20 > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_ide95&alloc_id=14396&opclick > _______________________________________________ > enlightenment-devel mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > |