Re: [E-devel] Engage / strcmp v. strncmp

[Frederick H. <fw...@sc...>]

> Frederick Heckel wrote:
>> On Fri, 17 Dec 2004 21:57:25 +0000 Andrew Elcock <an...@el...>
>> claimed:
>>
>>>It should not be listening to directories at all - see how it passes 0
>>>as the recurse setup bit? anyhow all .eet icons will be moved to .eapp
>>>soon, so this code will change.
>>>
>>>as for null winclasses - if (winclass && ...
>>>is just wrong - if you have a null winclass the icon is not valid for
>>>engage, it requires winclass to function properly...
>>
>>
>> Fair enough. Since the directory nodes are structural, I'd suggest that
>> null checks on the app->winclass field may serve perfectly well to
>> ignore them as apps--
>
> no - apps with no winclass != dirs

But if dirs == apps with no winclass, dirs should be ignored as apps(but
recursing into them potentially adds new apps to the tree, and so serve as
structural nodes), and apps with no winclass == invalid, why not just put
a null check in to fix the problem of dirs causing crashes because they
have no winclass until the new code goes into the repository?

(fwph)

--
Frederick Heckel
fw...@sc...
http://battletothedeath.net