Re: [E-devel] Re: E CVS: libs/ecore tsauerbeck

[Ibukun O. <ib...@co...>]

On Fri 27 Aug 2004, Tilman Sauerbeck wrote:
> Ibukun Olumuyiwa <ib...@co...> [2004-08-27 16:38]:
> > On Fri 27 Aug 2004, enl...@li... wrote:
> > > Enlightenment CVS committal
> > > 
> > > Author  : tsauerbeck
> > > Project : e17
> > > Module  : libs/ecore
> > > 
> > > Dir     : e17/libs/ecore/src/lib/ecore_evas
> > > 
> > > 
> > > Modified Files:
> > > 	Ecore_Evas.h.in ecore_evas_x.c 
> > > 
> > > 
> > > Log Message:
> > > added ecore_evas_gl_x11_window_get()
> > 
> > Is this not redundant? It doesn't do anything different from
> > software_x11_window_get() as far as I can see. Feels like unneeded bloat.
> 
> Yes, but the function name clearly indicates that its specific to the
> engine that's used so it makes sense to have an extra function for the
> GLX11 engine.
> 

So why not rename the function to ecore_evas_x11_window_get() or something
similar? I know it's massive api breakage, but it should be trivially easy
to fix throughout CVS. I guess I just don't fancy the idea of having two
different functions in the same file that do the exact same thing.

-- 

Ibukun Olumuyiwa
http://xcomputerman.com

"God is dead." - Nietzche
"Nietzche is dead." - God