From: Sebastian K. <se...@hi...> - 2014-04-18 19:08:16
|
On 4/18/14 11:22 , Bence Kovács wrote: > Hello Sebastian, > > Thank you for your remarks. > I corrected both and made the commits and branch naming more consequent. > > Please push branch general-mechatronics-driver-v112. Pushed! Thanks for fixing the GM driver, and for resolving the nitpick issues i raised. :-) > In case you have any more comment or you see mistake I should correct, > please write. Further advices are always welcome. One more comment, for next time. Please format your commit messages according to section 7.2 of this document: http://linuxcnc.org/docs/devel/html/code/Contributing-to-LinuxCNC.html Specifically, if you make the first line of the commit message into a brief description of the commit, it makes the git log easier to read. -- Sebastian Kuzminsky |