Menu

#81 groupchat buffer keeps popping up

open-fixed
None
5
2012-02-06
2012-02-02
No

With the current git HEAD, for at least one of my jabber contacts, an unrequested group chat buffer will appear almost immediately after I open a regular buffer for that contact. if i close the groupchat buffer, it will not reappear as long as the regular buffer stays open. If I delete the regular buffer and open create it anew, the groupchat buffer reappears, too. The problem is reproducible for that contact. version 0.8.0 does not have it.

Discussion

  • Magnus Henoch

    Magnus Henoch - 2012-02-03

    Sounds like an incoming message is incorrectly treated as a groupchat message. Could you set jabber-debug-log-xml to t and paste messages from that contact here?

     
  • Magnus Henoch

    Magnus Henoch - 2012-02-03
    • assigned_to: nobody --> legoscia
     
  • Elias Pipping

    Elias Pipping - 2012-02-03

    I replaced the:
    * name and host of that contact with HIS_NAME@HIS_HOST,
    * my name and host with MY_NAME@MY_HOST, and
    * my IP with MY_IP
    * my password with PASSWORD
    in the log. I also stripped all messages related to other contacts. The result is attached;

     
  • Elias Pipping

    Elias Pipping - 2012-02-03

    log

     
  • Magnus Henoch

    Magnus Henoch - 2012-02-05

    Right, I found the problem. In jabber-roster-ret-action-at-point, we try to DTRT, i.e. open a chat buffer if the roster item is a contact and a groupchat buffer if the roster item is a chatroom. Normally, jabber.el will refuse to open a groupchat buffer if the JID is not a chatroom (as determined by disco), but your contact's server returns a feature-not-implemented error in response to the disco info request. Since at least one MUC server actually does that (ejabberd's mod_irc), jabber.el will give it the benefit of the doubt and open a groupchat buffer anyway...

    So... the right answer is probably to make RET in a roster buffer open a groupchat only if the JID actually says it's a groupchat, disabling the feature-not-implemented hack for this case, so you'd have to join non-compliant rooms with an explicit M-x jabber-muc-join.

    Out of interest, could you check what server this is? I.e. M-x jabber-get-version or M-x jabber-get-disco-info on HIS_HOST.

     
  • Elias Pipping

    Elias Pipping - 2012-02-05

    version request log

     
  • Elias Pipping

    Elias Pipping - 2012-02-05

    they don't seem too eager to tell anyone anything.

    there's a good chance they're running ejabberd, though.

     
  • Elias Pipping

    Elias Pipping - 2012-02-05

    (since i didn't get a mail that notified me of the attachment i just added, i'm making it explicit here)

     
  • Magnus Henoch

    Magnus Henoch - 2012-02-06

    Right, that's the behaviour you'd get from ejabberd with mod_disco disabled.

    I just pushed a fix to git. Could you try it? It's a small change to jabber-roster.el.

     
  • Elias Pipping

    Elias Pipping - 2012-02-06

    That appears to fix it, thanks.

     
  • Elias Pipping

    Elias Pipping - 2012-02-06
    • status: open --> open-fixed
     
  • Elias Pipping

    Elias Pipping - 2012-02-06

    This change isn't in 0.8.91, right?

     
  • Lukas Fuernkranz

    I'm affected as well by this annoyance, however I don't get where I can download the patch and how to apply it... tia and sorry for the silly question.

     

Log in to post a comment.