[eGroupWare-tracker] Bugs #2992: notification for events - SENDER sometimes not the OWNER of event ??

[<tr...@eg...>]

Ticket modified by camel camel at 2011/07/13 00:09: 
Tracking System: Bugs
Category: Calendar
Version: Trunk
Status: Open
Resolution: None
Completed: 0%
Priority: 5 - medium
Created by: camel camel
Created on: 2011/06/20 19:52
Assigned to: Ralf Becker
Summary: #2992 - notification for events - SENDER sometimes not the OWNER of event ??
this bug does not happen always ...
(maybe if another user change a event .. but not always)

i have an EVENT with alarm for user "A" and no invite to any other user or participants in there. Also activated in settings, to send notification via email if event will be changed.

Then user "B" change the event, and the owner get an email.
so far - so good ...

BUT THE SENDER of this notification is anyone user of the system (not user "A")

(10 other users have the right to view the events of user "A")

hmm, i have no idea to fix that ....
maybe can it be, that the service can't find the session user, and so it use any other user as sender ?

is it possible to include an extra check for that ?
----------------------------------------------------------------
> : Comment by camel camel at 2011/07/13 00:09:
i fixed that via doing the senderid always to modifier ...
i mean, so it is possible to change via async service,too

would it be better to change the sender always to modifier ?

################################################################
class.calendar_boupdate.inc.php   [----]  8 L:[649+39 688/2525] *(24416/82349b) 0009 0x009
            $GLOBALS['egw_info']['user']['preferences'] = $GLOBALS['egw']->preferences->read_repository();
        }

-      $senderid = $this->user;
+        $senderid = $new_event ? $new_event['modifier'] : $old_event['modifier'];

####################################
or it could be done on this way ...
####################################

class.calendar_boupdate.inc.php   [----]  8 L:[649+39 688/2525] *(24416/82349b) 0009 0x009
            $GLOBALS['egw_info']['user']['preferences'] = $GLOBALS['egw']->preferences->read_repository();
        }

-      $senderid = $this->user;
+        $senderid = $new_event ? $new_event['modifier'] : $this->user;


Sent By:Linux fpm0.farm03.stylite.de 2.6.18-238.5.1.el5.centos.plus #1 SMP Mon Apr 4 18:19:56 EDT 2011 x86_64
Linked entries:
https://community.egroupware.org/egroupware/index.php?menuaction=tracker.tracker_ui.edit&tr_id=2992&no_popup=1