Menu
▾
▴
Re: [eGroupWare-developers] egroupware addressbook
|
From: Frank-braucht-Hilfe <fra...@di...> - 2007-03-26 08:57:05
|
Hi Klaus,
sounds very good. I dont know where to insert it. I think its somewhere in
class.uicontacts.inc.php. Can you tell me on which place to insert this cod=
e
exactly, than I will check it out, too.
Thanks Frank
Klaus Leithoff wrote:
>=20
> I found a even simpler solution, setting an additional col_filter will do
> the work.
> This works with 1.3.0.15; I tested against our production system.
> Around 3600 Adresses, 35 Accounts.
> I did not have a trunk version at hand, at home, so I will test that om
> monday.
> But I expect that to work as well
>=20
> if ($this->prefs['hide_accounts'] )
> $query['col_filter']['account_id']=3Dnull;
> $rows =3D parent::search($query['advanced_search'] ?
> $query['advanced_search'] :
> $query['search'],false,
> $order,'',$wildcard,false,$op,array((int)$query['start'],(int)
> $query['num_rows']),$query['col_filter']);
>=20
> Regards
> Klaus
>=20
> Klaus Leithoff <kl...@st...> schrieb:
>>Hi, there seems to be a problem with my method of doing it, when you
>>search
>>anything via the nextmatch methods AND have the Useraccounts hidden.
>>(at least within 1.3.0.15)
>>I will think about it during the weekend.
>>Regards
>>Klaus
>>
>>
>>Frank-braucht-Hilfe <fra...@di...> schrieb:
>>>>Hi,>>okay, I can do the testing regarding big addressbooks. Their are
>>already
>>>500>entries in our addressbook, but only 30 users.>Are their some
>>validation criterias? How many addresses/ users do I have
>>>to>add?>>I am not using LDAP, so cant check this out. As the code is
>>only
>>optional,
>>>I>propse to add an explaining line like:>- tested with SQL-addressbook
>>and
>>users only into the preferences ->>Or anybody who wants to check the code
>>for LDAP, too?>>Below the code change consolidated of the two mails of
>>Klaus:>>Just for testing reasons I have added the two phps, which are
>>based on
>>>the>trunk-version about three weeks ago (dont know if upload of two
>>files
>>die>succeed). I properly layouted and written code based on the current
>>trunk>can be provided by me later.>>best wishes Frank>>You add:> =
=20
>>
>> //show accounts in listing> =20
>>$GLOBALS['settings']['hide_accounts'] =3D array(> =
=20
>>'type' =3D> 'check',> 'label' =3D> 'Hide accoun=
ts
>>in
>>addressbooklist',> 'name' =3D> 'hide_accounts',>=
=20
>>
>> 'help' =3D> 'Hide accounts in the adressbooklist',> =
=20
>>
>> 'xmlrpc' =3D> True,> 'admin' =
=3D>
>>false,> );>to class.contacts_admin_prefs.inc.php>function
>>settings()>>Next you change line 669 (just before the call of search)>to
>>class.uicontacts.inc.php>if ($this->prefs['hide_accounts']) $join=3D",
>>(select account_id as>accountid, contact_id as contactid from
>>egw_addressbook WHERE>egw_addressbook.account_id is null) addbook2
>>WHERE>addbook2.contactid=3Degw_addressbook.contact_id ";>>You change line
>>670/671, and add , $join just before the closing bracket>$rows =3D
>>parent::search($query['advanced_search'] ?>$query['advanced_search']
>>:>$query['search'],false,>$order,'',$wildcard,false,$op,array((int)$query=
['start'],(int)>$query['num_rows']),$query['col_filter'],$join);>>You
>>conditionally set $addressbooks[0] (now in line 898)>if
>>(!$this->prefs['hide_accounts']) $addressbooks[0] =3D
>>lang('Accounts');>>Line
>>references may differ but the context should be obvious through the>lines
>>of code provided. >>>>Das Verhalten bei grossen Adressb=C3=BCchern steht =
noch
>>zu
>>pr=C3=BCfen :-(>Ist noch nicht getestet. Genausowenig, wie der Zugriff au=
f
>>>LDAP
>>Adressb=C3=BCcher :-(>Gr=C3=BCsse>Klaus>>The behavior with large adressbo=
oks is yet
>>untested.>As well as the behavior with LDAP
>>adressbooks.>Regards.>Klaus>>>-- >View this message in context:
>>>http://www.nabble.com/egroupware-addressbook-tf3027656s3741.html#a961853=
3>Sent
>>from the egroupware-developers mailing list archive at
>>Nabble.com.>>>-----------------------------------------------------------=
-------------->Take
>>Surveys. Earn Cash. Influence the Future of IT>Join SourceForge.net's
>>Techsay panel and you'll get the chance to share
>>>your>opinions on IT & business topics through brief surveys-and earn
>>cash>http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C=
ID=3DDEVDEV>_______________________________________________>eGroupWare-deve=
lopers
>>mailing
>>list>eGr...@li...>https://lists.sourceforg=
e.net/lists/listinfo/egroupware-developers>>
>>
>>--
>>Klaus Leithoff
>>Stylite GmbH
>>[ open style of IT ]
>>
>>Morschheimer Strasse 15
>>D
>>- 67292 Kirchheimbolanden
>>
>>fon 06352 . 70629-0
>>fax 06352 . 70629-30
>>email
>> href=3D"../../../../index.php?menuaction=3Dfelamimail.uicompose.compose&=
send_to=3DZ21Ac3R5bGl0ZS5kZQ=3D=3D">kl...@st...=20
>>www.stylite.de
>>
>>
>>
>>Gesch=C3=A4ftsf=C3=BChrer: Nigel John Vickers, Andre Keller
>>Registergericht
>>Kaiserslautern, HRB 12087
>>
>>
>>
>>
>>
>>-------------------------------------------------------------------------
>>Take Surveys. Earn Cash. Influence the Future of IT
>>Join SourceForge.net's Techsay panel and you'll get the chance to share
>>your
>>opinions on IT & business topics through brief surveys-and earn cash
>>http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV
>>_______________________________________________
>>eGroupWare-developers mailing list
>>eGr...@li...
>>https://lists.sourceforge.net/lists/listinfo/egroupware-developers
>>
>>>
>=20
> --
> Klaus Leithoff
> Stylite GmbH
> [ open style of IT ]
>=20
> Morschheimer Strasse 15
> D
> - 67292 Kirchheimbolanden
>=20
> fon 06352 . 70629-0
> fax 06352 . 70629-30
> email
>=20
> ../../../../index.php?menuaction=3Dfelamimail.uicompose.compose&send_to=
=3DZ21Ac3R5bGl0ZS5kZQ=3D=3D
> kl...@st...=20
> www.stylite.de
>=20
>=20
>=20
> Gesch=C3=A4ftsf=C3=BChrer: Nigel John Vickers, Andre Keller
> Registergericht
> Kaiserslautern, HRB 12087
>=20
>=20
>=20
>=20
>=20
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV
> _______________________________________________
> eGroupWare-developers mailing list
> eGr...@li...
> https://lists.sourceforge.net/lists/listinfo/egroupware-developers
>=20
>=20
--=20
View this message in context: http://www.nabble.com/egroupware-addressbook-=
tf3027656s3741.html#a9669633
Sent from the egroupware-developers mailing list archive at Nabble.com.
|