Menu
▾
▴
[eGroupWare-tracker] [ egroupware-Bugs-1150972 ] Link issue
|
From: SourceForge.net <no...@so...> - 2005-05-27 09:04:07
|
Bugs item #1150972, was opened at 2005-02-24 13:05 Message generated for change (Comment added) made by ralfbecker You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=554338&aid=1150972&group_id=78745 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: infolog Group: 1.0 release branch >Status: Pending Resolution: Fixed Priority: 5 Submitted By: Dave Herman (dah16) Assigned to: Ralf Becker (ralfbecker) Summary: Link issue Initial Comment: When I insert a link that contains an ampersand ('&') into the description field of infolog, the link does not work correctly. example: http://www.egroupware.orgegroupware/index.php?menuaction=workflow.run_activity.go&activity_id=3 The hyperlink itself truncates after the ampersand: http://www.egroupware.org/egroupware/index.php?menuaction=workflow.run_activity.go This bug needs to be fixed so that workflow can be used with the infolog. Potential Workarounds that I have tried (but won't work): 1. Put the link inside of an HTML href tag, 2. Put a delimiter like a slash or second ampersand in front of the ampersand. 3. Encode the URL. I have recreated this bug on the demo site. There is a task created on 23 Feb called Test Link that recreates the problem. ---------------------------------------------------------------------- >Comment By: Ralf Becker (ralfbecker) Date: 2005-05-27 11:03 Message: Logged In: YES user_id=208526 Hi, the bugfix is in the file phpgwapi/inc/class.html.inc.php in the method activate_links: cvs -f -Q diff -N -b -B -kk -r 1.30.2.10 -r 1.30.2.11 "class.html.inc.php" Index: class.html.inc.php =================================================================== RCS file: /cvsroot/egroupware/phpgwapi/inc/class.html.inc.php,v retrieving revision 1.30.2.10 retrieving revision 1.30.2.11 diff -b -B -r1.30.2.10 -r1.30.2.11 113c113 < $Subdir = '([\w\-\.,@?^=%&:\/~\+#]*[\w\-\@?^=%&\/~\+#])?'; --- > $Subdir = '([\w\-\.,@?^=%&;:\/~\+#]*[\w\-\@?^=%&\/~\+#])?'; Ralf ---------------------------------------------------------------------- Comment By: Dave Herman (dah16) Date: 2005-03-01 19:53 Message: Logged In: YES user_id=597852 I have updated from CVS, but am still having the same problem. Running infolog 1.0.0.001 and phpgwapi is 1.0.1.004 from CVS. Can you tell me where to look for the fix in the code? ---------------------------------------------------------------------- Comment By: Dave Herman (dah16) Date: 2005-02-24 13:37 Message: Logged In: YES user_id=597852 One other point - I frequently link to pages outside of egroupware from infolog, so adding workflow as an option on the links tab of the infolog entry would not be the best solution. ---------------------------------------------------------------------- Comment By: Ralf Becker (ralfbecker) Date: 2005-02-24 13:27 Message: Logged In: YES user_id=208526 Hi, this bug is fixed since 1-2 weeks. Just make a cvs update or wait for the next bugfix release. Ralf ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=554338&aid=1150972&group_id=78745 |