Re: [eclipsedarcs-develop] [PATCH] Tidyup + Factory Generalizations + Other tidbits

[Leif F. <lfr...@in...>]

Hi Isaac,

>I'm pretty sure I ran source-format(Esc-crtl-f) on the files I
>modified. Or is that not doing the right thing? I'm happy with the sun
>guidelines. I don't care whether we have tabs or not.
>
>  
>
Yes, that should do the trick normally. Anyway, my checkstyle marks them 
immediately, so I just remove them always quietly ;-)

I think I will create a wiki page, so that we can assemble a small list 
of conventions we use which we can point new developers at.

>>The other thing: We should decide whether we need to internationalize
>>log messages. Personally, I always feel that developers need a working
>>knowledge of English, so I'm usually too lazy to externalize and
>>translate everything that doesn't get to the user (in dialogs etc.). So
>>I suggest we create i18n keys only for things the user is likely to see,
>>and keep to writing simple strings to the log (or to the trace). It
>>makes the code a bit better readable. Comments welcome on that topic too ...
>>    
>>
>
>Happy with that too. We also have to distingish what goes on the log
>and what goes on the trace.
>  
>
Yupp. My rule of thumb is that nothing should go into the log that 
regularly occurs, so that we don't bloat the logfile. If everything runs 
smoothly, the log should show nothing that comes from us. Only problems 
that were unexpected or such we could not recover from should go to the 
log, so that we can ask users to send us the log if they notice 
something is not ok. The trace is more like 'Debuglevel info', so that 
we can write into it whatever we like.

Ciao,
Leif

>  
>
>>>As a result of the Factory/Manager changes quite a lot of code is now
>>>in NewRepositoryLocationWizard.performFinish - is that kind of code
>>>supposed to go there? Should an Action class or something be made for
>>>that?
>>>      
>>>
>>Yes I think that would be preferable, especially because Radek will
>>probably use them in his dialogs too, so we can avoid a bit of redundancy.
>>
>>Thanks && ciao,
>>Leif
>>
>>    
>>
>
>thanks,
>Isaac Devine
>
>
>-------------------------------------------------------
>SF.Net email is Sponsored by the Better Software Conference & EXPO
>September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
>Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
>Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
>_______________________________________________
>eclipsedarcs-develop mailing list
>ecl...@li...
>https://lists.sourceforge.net/lists/listinfo/eclipsedarcs-develop
>
>  
>