[eclipsedarcs-develop] [PATCH] Tidyup + Factory Generalizations + Other tidbits
Status: Alpha
Brought to you by:
radoslawg
From: Isaac D. <isa...@gm...> - 2005-08-07 04:00:38
|
Hi all, Summary of Changes: 1. This set of patches move the Repo...Exception class into the repository package. 2. Seperates the creation components of RepositoryLocationManager into a new class called RepositoryFactory. 3. Changes the RepositoryFactory to use a general validation method of Validator which simplifies a the repository creation code. 4. PersistUtil and RepositoryManager now use a Set - So there cannot be more than one Repository with the same URI. Currently when this is attempted in the Browsing View it is just silently ignored - I don't think that is desirable. Any ideas on what to tell the user in that case? 5. Fixed up my tracing logic as per discussion here: http://sourceforge.net/mailarchive/message.php?msg_id=3D12489158 As a result of the Factory/Manager changes quite a lot of code is now in NewRepositoryLocationWizard.performFinish - is that kind of code supposed to go there? Should an Action class or something be made for that? thanks, Isaac Devine |