Re: [eclipsedarcs-develop] Eclipsedarcs preference page

[Leif F. <hi...@le...>]

Hi Radek,

>   I think I did it. :)
Great :-)

>   At least I think I did it correctly. Please, remember I am beginning
> my journey through PDE and stuff. Any comments are appriciated.
>   I did a little research and the way I have implemented it follows
> subclipse plugin technique and more or less cvs plugin.
>   Doing visual side of preference page wasn't at all difficult. I am
> impressed really. But what gave me headache was Plugin Preferenence
> storage system. :/
Yes, this is a bit confusing, I have always wondered about these 
different ways to maintain preferences a little. My own strategy is to 
use the IPreferenceStore only for pure UI settings (things like syntax 
colors in editors etc.). For core preferences (like the AUTHOR thing) I 
just use the PluginPreferences. This involves more coding on the 
preference pages, though (you have to maintain the state yourself and 
call savePluginPreferences() on the plugin at the appropriate time. But 
sometimes you want to do this anyway (e.g. when you want a preference 
page with tabs). I did a lot of experimentation with that in my other 
plugin project (eclipsefp.s.net). You could have a look at that if you like.

But if you found another solution, I'm fine with that, as long as it 
works. We can always refactor later, if the need emerges.

>   I would appriciate reviewing the code I send...
>   And about sending the code. We haven't discussed that yet. How
> should I upload my changes to the repository? I wouldn't like to screw
> anything so just give me some point guides.
Well, the most straightforward procedure would probably be if you would 
just mail me a patch (darcs send -o patch.txt). I could easy apply that 
to my working repo and later push to the repo on the site. I would very 
much like to have a look into the code that is to go into the repo, so 
this approch would fit me fine. Still, the patch would carry your code 
and your email, and any possible changes I would make would be in a 
second patch on top of it, so we would keep the exact history of the 
development. (One of the cool things about Darcs :-)

Or we could make it a practice to send patches to the mailing list 
generally, so that we can share code that's in development between 
developers, and people who want to just pull the latest state could do 
so from the repo still. (Although we may well wait for the number of 
developers to grow a little before that is really needed ;-)

What do you think?

Ciao,
Leif
> 
> Cheers,
> 
>   Radek.