From: <kla...@sd...> - 2007-06-08 15:40:36
|
But i have tested ediff with ECB 5 min ago - with a CVS-build of Emacs = 22 (some weeks old) and also the current official release 22.1! It works = like a charm running Ediff in ECB - hitting 'q' quits ediff and restores = the previous window-layout... so i can not reproduce it.... =20 have you tested it also with a clean "vanilla" Emacs which has only = loaded ECB and cedet...?? =20 Klaus ________________________________ From: Perry Smith [mailto:pe...@ea...]=20 Sent: Friday, June 08, 2007 5:34 PM To: Oviedo Javier-PKJ843 Cc: Berndl, Klaus; Chr...@3c...; = ecb...@li... Subject: Re: [ECB-list] ECB and Ediff I'm puzzled. This happens to me sooo often that I assume it is my = fault.=20 I sent a note out about ediff-buffer weeks ago and got NO reply at all. = Why is it that this message generates tons of emails but my questions do = not generate squat.=20 Perry Smith ( pe...@ea... ) Ease Software, Inc. ( http://www.easesoftware.com ) Low cost SATA Disk Systems for IBMs p5, pSeries, and RS/6000 AIX systems On Jun 8, 2007, at 10:26 AM, Oviedo Javier-PKJ843 wrote: Hi Klaus, =20 Does not help, unfortunately. I removeed (and verified that the value = was really removed) and the problem still happens. I see the same error = reported previously. =20 Yes, I am using a pre-compiled CVS version of emacs. Got it off the web = from http://www.crasseux.com/emacs/ =20 Javier =20 ________________________________ From: kla...@sd... [mailto:kla...@sd...]=20 Sent: Friday, June 08, 2007 11:17 AM To: Oviedo Javier-PKJ843; Chr...@3c...; = ecb...@li... Subject: RE: [ECB-list] ECB and Ediff =09 =09 well, very important is the Emacs version you use... =20 I strongly suppose you use either the new Emacs 22 or a CVS-build of = it, right? Reason for my assumption: Emacs 22 has completely rewritten = balance-windows, which is adviced by ECB - but the ECB-advice works not = very well with Emacs 22-version of balance-window... see here my = TODO-marker in the layout-code of ECB next to the advice: =20 ;; TODO: Klaus Berndl <kla...@sd...>: We need a new solution = which ;; temporally sets `window-size-fixed' to t for all current visible = special ;; ecb-buffers (and the compile-window) and then calls ad-do-it - this = is necessary because latest ;; cvs-Emacs 22 has reimplemented balance-windows so it is not longer = based on ;; walk-windows but uses a completely new mechanism based on a ;; c-level-function `window-tree'! Probably the window-size-fixed = version will ;; also work with Emacs 21.3 and XEmacs - we will check this... (defadvice balance-windows (around ecb) "When called in the `ecb-frame' then only the edit-windows are = balanced." (ecb-with-ecb-advice 'walk-windows 'around ad-do-it)) =09 =20 Does it help if you remove balance-windows from this option: = ecb-advice-window-functions?? =20 Ciao, Klaus ________________________________ From: Oviedo Javier-PKJ843 [mailto:jo...@mo...]=20 Sent: Friday, June 08, 2007 5:02 PM To: Berndl, Klaus; Chr...@3c...; = ecb...@li... Subject: RE: [ECB-list] ECB and Ediff =09 =09 Hi. =20 I did exit ediff using q. When doing so I noticed the following error: =20 =09 Quit this Ediff session? (y or n)=20 ad-Orig-balance-windows: Wrong type argument: number-or-marker-p, = #<window 11 on input1.txt> =09 ecb-run-ediff-in-ecb-frame is set to t. Seems that above error is = probably my culprit. =20 Will write a full bug report shortly... =20 Thanks! Javier =20 ________________________________ From: kla...@sd... [mailto:kla...@sd...]=20 Sent: Friday, June 08, 2007 10:35 AM To: Chr...@3c...; Oviedo Javier-PKJ843; = ecb...@li... Subject: RE: [ECB-list] ECB and Ediff =09 =09 Hi, =20 Chris is right - quitting ediff with "q" is IMHO the only way it = should be done! Even when running Ediff without ECB this is the = recommended way to quit an ediff-session - Javier, please read also the = ediff-manuall... =20 To point 1: This is necessary, beaucse ediff has its own = window-manager which works only well if "it" can get control over the = whole frame - so ECB hide temporally its special windows and also its = compile-window - if visible... ECB stores the whole window-config of the = edit-window (its splitting-state)... =20 To point 2: After quiting the ediff-session correctly (with 'q' as = described in the ediff-manual) ECB restores the full window-config as = before ediff has been started - i.e. displays the special ecb-windows if = they were visible before starting ediff - same for the compile -window! =20 It costs me hard work and studying the ediff-code and hooks to make = ECB running well and conveniant with ediff and vice versa - so please = use ediff as ediff is meant to be used without ECB; this includes = quitting ediff only in a way ediff should be quitted, i.e. only with = 'q'... =20 =20 See also the option =20 (defcustom ecb-run-ediff-in-ecb-frame t "*Run ediff-sessions in the same frame as ECB is running. If not nil then ECB ensures that ediff runs in the same frame as ECB = and ECB restores exactly the \"before-ediff\"-window-layout after quiting = ediff. If nil then ediff decides in which frame it will run - depending on the = current window-layout \(e.g. if the ecb-windows are currently hidden) this = can be the ecb-frame but this can also be a newly created frame or any other = frame." :group 'ecb-general :type 'boolean) =09 So, you see apropos is always your friend ;-) =20 Does this help and work for you? =20 Klaus =09 =09 ________________________________ From: Chr...@3c... [mailto:Chr...@3c...]=20 Sent: Friday, June 08, 2007 4:00 PM To: jo...@mo...; ecb...@li... Cc: Berndl, Klaus Subject: RE: [ECB-list] ECB and Ediff =09 =09 How did you terminate your ediff session? If you press "q" to quit = ediff, ecb windows should be restored. However, if you "C-x k" the = small ediff window, you'll see the behavior you describe. =20 =09 --=20 Chris Britton br...@te... ________________________________ From: ecb...@li... = [mailto:ecb...@li...] On Behalf Of Oviedo = Javier-PKJ843 Sent: Thursday, June 07, 2007 10:23 AM To: ecb...@li... Cc: kla...@sd... Subject: [ECB-list] ECB and Ediff =09 =09 Hi all, =20 Just tried using ediff for the first time today (believe it or not = :-). I noticed several issues when using ECB with Ediff: =20 1. Ediff overwrites the windows layout of ECB with it's own = layout...non edit windows in ECB disappear and ediff splits the edit = window for comparison. =20 2. Once I completed using Ediff I tried redrawing the ECB layout, in = hopes of returning all previously established windows, but ECB does not = seem able to recover. =20 Is there a a way to address either of these issues? The first one = wouldn't be so bad if the layout could be redrawn after the diff is = complete. Still thought it would be very nice if I could find a way for = ECB to have ediff split the edit window and leave the other ones intact. =20 Hope this description makes sense.... =20 Thanks! Javier =20 CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is being sent by 3Com for the sole use of the intended recipient(s) and may contain confidential, proprietary and/or privileged information. Any unauthorized review, use, disclosure and/or distribution by any=20 recipient is prohibited. If you are not the intended recipient, please delete and/or destroy all copies of this message regardless of form and any included attachments and notify 3Com immediately by contacting the sender via reply e-mail or forwarding to 3Com at pos...@3c....=20 = -------------------------------------------------------------------------= This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. = http://sourceforge.net/powerbar/db2/_____________________________________= __________ Ecb-list mailing list Ecb...@li... https://lists.sourceforge.net/lists/listinfo/ecb-list |