Re: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0

[徐永健 <xuy...@gm...>]

The check is not right, it should be "(int)(skb->len) <= 0", or we
just remove this check if "skb->len will never be negative or 0".

2014-05-13 22:57 GMT+08:00 Ronciak, John <joh...@in...>:
>> -----Original Message-----
>> From: xuy...@gm... [mailto:xuy...@gm...]
>> Sent: Monday, May 12, 2014 10:07 PM
>> To: eri...@gm...
>> Cc: e10...@li...; ne...@vg...; linux-
>> ke...@vg...; Yongjian Xu
>> Subject: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0
>>
>> From: Yongjian Xu <xuy...@gm...>
>>
>> There is no case skb->len would be 0 or 'negative'.
>> Remove the check.
>>
>> Signed-off-by: Yongjian Xu <xuy...@gm...>
>> ---
>>  drivers/net/ethernet/intel/e1000/e1000_main.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
>> b/drivers/net/ethernet/intel/e1000/e1000_main.c
>> index 27058df..660971f 100644
>> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
>> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
>> @@ -3105,11 +3105,6 @@ static netdev_tx_t e1000_xmit_frame(struct
>> sk_buff *skb,
>>        */
>>       tx_ring = adapter->tx_ring;
>>
>> -     if (unlikely(skb->len <= 0)) {
>> -             dev_kfree_skb_any(skb);
>> -             return NETDEV_TX_OK;
>> -     }
>> -
>>       /* On PCI/PCI-X HW, if packet size is less than ETH_ZLEN,
>>        * packets may get corrupted during padding by HW.
>>        * To WA this issue, pad all small packets manually.
>> --
>> 1.9.1
> What is the exact problem that this is fixing?  Did you have a test case that showed a problem with it?
>
> Cheers,
> John
>
>