EPIC - Eclipse Perl Integration / Bugs / #609 Perl::Critic additional options not used correctly

#609 Perl::Critic additional options not used correctly

Milestone: v0.6.x

Status: closed-fixed

Owner: nobody

Labels: Core (65)

Priority: 5

Updated: 2011-02-21

Created: 2010-12-10

Creator: Oliver Trosien

Private: No

SourceCritic.java is adding the additional critic options string as single commandline option. This means that you cannot put sth like --profile pathtoyourprofile or multiple options into the text field.

Discussion

Oliver Trosien - 2010-12-10

trivial fix, does not work for quoted strings containing spaces

org_epic_perleditor_additionalcriticargs.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Ploski - 2010-12-10

See org/epic/perleditor/editors/util/SourceFormatter.java for how it should be done properly (via CommandLineTokenizer).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oliver Trosien - 2010-12-13

fixed patch.

org_epic_perleditor_additionalcriticargs2.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oliver Trosien - 2011-02-21

Fixed in CVS

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Oliver Trosien - 2011-02-21

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Ploski - 2011-04-22

Fixed in 0.6.40.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Perl::Critic additional options not used correctly

Group

Searches

Help

#609 Perl::Critic additional options not used correctly

Discussion