Re: [Dvdauthor-developer] Check for FRIBIDI2 (FriBidiParType) in configure.ac is broken because it's not using CFLAGS from fribidi.pc (pkg-config)

[Samuli S. <ssu...@ge...>]

On 05/24/2012 10:49 AM, Lawrence D'Oliveiro wrote:
> On Tue, 22 May 2012 13:07:13 +0300, Samuli Suominen wrote:
>
>> This check in configure.ac is not working:
>>
>> AC_CHECK_TYPE(FriBidiParType, [AC_DEFINE(HAVE_FRIBIDI2, 1, [Whether
>> Fribidi is version 2])], [], [#include
>> <fribidi/fribidi-bidi-types.h>])
>>
>> Because it's not getting the CFLAGS from fribidi.pc first:
>>
>> configure:5111: checking for FriBidiParType
>> configure:5111: x86_64-pc-linux-gnu-gcc -c -march=native -O2 -pipe
>> conftest.c>&5
>> In file included from /usr/include/fribidi/fribidi-bidi-types.h:36:0,
>>                    from conftest.c:29:
>> /usr/include/fribidi/fribidi-common.h:65:20: fatal error: glib.h: No
>> such file or directory
>
> I don’t understand what the issue is here. I have libfribidi-dev
> 0.19.2-3 installed on my Debian Unstable system, and line 65
> of /usr/include/fribidi/fribidi-common.h is this:
>
>      #  include<glib/gmacros.h>
>
> which is clearly not including glib.h. Where are you getting this
> different version of FriBidi?

Indeed. We ship fribidi in Gentoo with glib support always enabled. We 
had too many issues with it disabled.

And just to clarify:

And the reason for this minor (and unrelated) difference of <glib.h> and 
<glib/gmacros.h> is that starting from glib version 2.31 it doesn't 
allow including <glib/gmacros.h> separately anymore and <glib.h> should 
be included directly.

The <glib/gmacros.h> from glib-2.32.3 looks like this at the head of the 
file:

#if !defined (__GLIB_H_INSIDE__) && !defined (GLIB_COMPILATION)
#error "Only <glib.h> can be included directly."
#endif

Therefore we drop in this patch to fribidi-0.19.2:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-libs/fribidi/files/fribidi-0.19.2-glib-2.31.patch?view=markup

OK, replying to the patch test-request on the another message now... Moment.

- Samuli