Re: [Dvdauthor-users] Small bug in subgen-image.c

[Lawrence D'O. <ld...@ge...>]

On 21/06/10 23:47, Niels Horn wrote:

> I've been using dvdauthor in combination with tovid and discovered
> that it sometimes gives an error about png images being too big, while
> they aren't.

On a 64-bit architecture, presumably? Big-endian, by any chance? (Just 
wondering why I never noticed this on my AMD64 machine.)

> The following patch (against the stable 0.6.18 version) solves it:

Thanks for that.

> @@ -271,7 +271,7 @@
>       assert(bit_depth==8); // 8bpp, not 1, 2, 4, or 16
>       assert(!(color_type&PNG_COLOR_MASK_PALETTE)); // not a palette
>       if( width>MAXX || height>MAXY ) {
> -        fprintf(stderr,"ERR: PNG %s is too big:
> %lux%lu\n",s->fname,width,height);
> +        fprintf(stderr,"ERR: PNG %s is too big:
> %lux%lu\n",s->fname,(long unsigned int)width,(long unsigned
> int)height);
>           png_destroy_read_struct(&ps,&pi,NULL);
>           return -1;
>       }

I would dispense with the casts, and take out the “l” modifiers on the 
format specifiers.

Normally I prefer to discuss patches on dvdauthor-developer: that’s the 
list for the technicalities of the source code, this list is for the 
technicalities of using the code.

Though I admit things might get blurred sometime...