From: Andrea A. <an...@su...> - 2000-12-19 20:29:50
|
On Tue, Dec 19, 2000 at 07:20:58PM +0100, Andrea Arcangeli wrote: > Index: dump/restore/Makefile.in > =================================================================== > RCS file: /cvsroot/dump/dump/restore/Makefile.in,v > retrieving revision 1.5 > diff -u -r1.5 Makefile.in > --- dump/restore/Makefile.in 2000/05/29 14:17:37 1.5 > +++ dump/restore/Makefile.in 2000/12/19 18:19:16 > @@ -5,7 +5,7 @@ > > @MCONFIG@ > > -CFLAGS= @CCOPTS@ -pipe $(OPT) $(DEFS) $(GINC) $(INC) @RESTOREDEBUG@ > +CFLAGS= @CCOPTS@ -pipe $(OPT) $(DEFS) $(GINC) $(INC) @RESTOREDEBUG@ -D_FILE_OFFSET_BITS=64 > LDFLAGS:= $(LDFLAGS) @STATIC@ > LIBS= $(GLIBS) -le2p @READLINE@ > DEPLIBS= ../compat/lib/libcompat.a Please reject the above one liner (you had to reject it anyways :) becase also `dump` (not only restore) needs to be compiled with -D_FILE_OFFSET_BITS=64 so that the output file is opened with O_LARGEFILE (otherwise max dump output filesize is 2G). I really dislike having to change all open() to make them to use O_LARGEFILE... I much prefer the ./configure --enable-largefile way that just adds the -D_FILE_OFFSET_BITS=64 param all over the dump package (dump and restore) as discussed previously. That's safe and cleaner. Other part of the patch looks fine, I'm finishing right now to restore a 5G dump, but I don't expect troubles. Thanks Stelian and Ted for the help! Andrea |