Re: [patch] nouveau: off by one in nv50_gpio_location()

[Ben S. <bs...@re...>]

On Thu, 2010-04-22 at 11:40 +0200, Dan Carpenter wrote:
> If "gpio->line" is 32 then "nv50_gpio_reg[gpio->line >> 3]" reads past the
> end of the array.
Thanks, picked up in the nouveau tree.

> 
> Signed-off-by: Dan Carpenter <er...@gm...>
> 
> diff --git a/drivers/gpu/drm/nouveau/nv50_gpio.c b/drivers/gpu/drm/nouveau/nv50_gpio.c
> index c61782b..bb47ad7 100644
> --- a/drivers/gpu/drm/nouveau/nv50_gpio.c
> +++ b/drivers/gpu/drm/nouveau/nv50_gpio.c
> @@ -31,7 +31,7 @@ nv50_gpio_location(struct dcb_gpio_entry *gpio, uint32_t *reg, uint32_t *shift)
>  {
>  	const uint32_t nv50_gpio_reg[4] = { 0xe104, 0xe108, 0xe280, 0xe284 };
>  
> -	if (gpio->line > 32)
> +	if (gpio->line >= 32)
>  		return -EINVAL;
>  
>  	*reg = nv50_gpio_reg[gpio->line >> 3];