Re: [Mesa3d-dev] [mesa] svga: Fix error: cannot take address of bit-field 'texture_target' in svga_tgsi.h

[Brian P. <br...@vm...>]

r300_translate_tex_filters() was missing the is_anisotropic parameter. 
  I fixed that, but there may be other issues.  Looks like some of the 
r300 code isn't c99.

-Brian


Sedat Dilek wrote:
> OK.
> 
> That's the next one :-)
> ...
> In file included from r300_emit.c:36:
> r300_state_inlines.h: In function ‘r300_translate_tex_filters’:
> r300_state_inlines.h:263: error: ‘is_anisotropic’ undeclared (first
> use in this function)
> r300_state_inlines.h:263: error: (Each undeclared identifier is
> reported only once
> r300_state_inlines.h:263: error: for each function it appears in.)
> make: *** [r300_emit.o] Error 1
> ...
> 
> I am having dinner, now
> 
> - Sedat -
> 
> On Wed, Jan 6, 2010 at 6:07 PM, Brian Paul <br...@vm...> wrote:
>> Sedat Dilek wrote:
>>> Hi,
>>>
>>> this patch fixes a build-error in mesa GIT master after...
>>>
>>> commit  251363e8f1287b54dc7734e690daf2ae96728faf (patch)
>>> "configs: set INTEL_LIBS, INTEL_CFLAGS, etcmaster"
>>>
>>>> From my build-log:
>>> ...
>>> In file included from svga_pipe_fs.c:37:
>>> svga_tgsi.h: In function 'svga_fs_key_size':
>>> svga_tgsi.h:122: error: cannot take address of bit-field 'texture_target'
>>> make[4]: *** [svga_pipe_fs.o] Error 1
>>>
>>> Might be introduced in...
>>>
>>> commit  955f51270bb60ad77dba049799587dc7c0fb4dda
>>> "Make sure we use only signed/unsigned ints with bitfields."
>>>
>>> Kind Regars,
>>> - Sedat -
>>>
>> I just fixed that.
>>
>> -Brian
>>