Re: [PATCH] drm/radeon/kms: add cvt mode if we only have lvds w/h and no edid

[Alex D. <ale...@gm...>]

2009/12/22 Alex Deucher <ale...@gm...>:
> 2009/12/22 Michel Dänzer <mi...@da...>:
>> On Tue, 2009-12-22 at 09:30 -0500, Alex Deucher wrote:
>>> >From 7c30bc1d04bd87dff00ff80c3cf7d8a0b8cf3e34 Mon Sep 17 00:00:00 2001
>>> From: Alex Deucher <ale...@gm...>
>>> Date: Tue, 22 Dec 2009 09:25:22 -0500
>>> Subject: [PATCH] drm/radeon/kms: add cvt mode if we only have lvds w/h
>>> and no edid
>>>
>>> This fixes LVDS on some mac laptops without a panel edid.
>>>
>>> Signed-off-by: Alex Deucher <ale...@gm...>
>>> ---
>>>  drivers/gpu/drm/radeon/radeon_connectors.c |    5 +++++
>>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
>>> b/drivers/gpu/drm/radeon/radeon_connectors.c
>>> index 8da06e1..0cbd3ef 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
>>> @@ -208,6 +208,11 @@ static struct drm_display_mode
>>> *radeon_fp_native_mode(struct drm_encoder *encode
>>>               drm_mode_set_name(mode);
>>>
>>>               DRM_DEBUG("Adding native panel mode %s\n", mode->name);
>>> +     } else if (native_mode->hdisplay != 0 &&
>>> +                native_mode->vdisplay != 0) {
>>> +             /* mac laptops without an edid */
>>> +             mode = drm_cvt_mode(dev, native_mode->hdisplay,
>>> native_mode->vdisplay, 60, true, false, false);
>>> +             DRM_DEBUG("Adding native panel mode %s\n", mode->name);
>>
>> Might be worth reflecting in the message that it's not really the native
>> mode but a generated approximation of it.
>
> Updated patch (v3) attached.

V4 attached with updated comments and debug message.

Alex