Re: r600/KMS: hdmi audio setup

[Luca T. <kro...@gm...>]

2009/12/19 Christian König <dea...@vo...>:
> Hi,
>
> Am Samstag, den 19.12.2009, 15:37 +0100 schrieb Luca Tettamanti:
>> - first of all, I have a M56 (RV630) which lacks the PCI audio
>> function, I guess in this case the audio shouldn't be enabled at all
> That's definitely a bug, AFAIK regarding HDMI audio the M56 is R500
> based and doesn't supports it at all.

Typo, sorry: it's a M76 (the core is a RV630).

>> - the r600_audio_update_hdmi callback: is it really necessary to call
>> it 10 times/sec, even if no audio is playing? In a "normal" audio
>> driver that would be done only on ALSA ->open (or maybe ->prepare)
>> functions, but in this case it's not clear to me how the two pieces
>> (drm and alsa) interacts (can someone point me to the relevant docs?).
>> Maybe a tighter integration between them is needed?
>
> The timer was just a workaround and known regression of the usermode
> ddx. The hardware is capable of raising an IRQ on audio start/stop (the
> IRQ gets actually raised on any change of the audio settings, which the
> video driver must recognize to update the various hdmi settings).

I see; still the driver could touch audio settings only when the audio
device is actually open, no?

> At the time of writing this patch the IRQ code wasn't available so I
> just used the same workaround as the ddx, we should get rid of it as
> soon as stable IRQ support is available.

Ok, cool :)

thanks,
Luca