Re: [patch 1/5] drm/via: add pci id for VIA VX800 chipset

[Thomas H. <th...@sh...>]

Dave Airlie wrote:
> On Wed, Nov 18, 2009 at 8:41 AM,  <ak...@li...> wrote:
>   
>> From: Thomas Schlichter <tho...@we...>
>>
>> The VIA DRM module is able to accelerate 2D video on the VX800 chipset,
>> thus add the corresponding PCI ID.  Accelerated 3D video is not
>> implemented.
>>
>> The modified VIA DRM module was tested with X.Org openchrome driver on a
>> Samsung NC20 netbook.  Video playback with xine requires nearly 30% less
>> CPU cycles.
>>     
>
> I think this was an mtrr missing workaround,
>
> I think we dropped this in favour of fixing things properly, correct
> me if I'm wrong.
>
> Thomas?
>
>   

Yes, this is being fixed elsewhere to have libpciaccess and kernel agree 
in the case where PAT is not enabled.

So as long as e don't have any explicit VX800 support in DRM, I suggest 
we leave this patch out.

/Thomas



> Dave.
>
>   
>> Signed-off-by: Thomas Schlichter <tho...@we...>
>> Cc: Dave Airlie <ai...@re...>
>>     
>
>   
>> Cc: Eric Anholt <er...@an...>
>> Signed-off-by: Andrew Morton <ak...@li...>
>> ---
>>
>>  include/drm/drm_pciids.h |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff -puN include/drm/drm_pciids.h~drm-via-add-pci-id-for-via-vx800-chipset include/drm/drm_pciids.h
>> --- a/include/drm/drm_pciids.h~drm-via-add-pci-id-for-via-vx800-chipset
>> +++ a/include/drm/drm_pciids.h
>> @@ -477,6 +477,7 @@
>>        {0x1106, 0x3343, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, \
>>        {0x1106, 0x3230, PCI_ANY_ID, PCI_ANY_ID, 0, 0, VIA_DX9_0}, \
>>        {0x1106, 0x3157, PCI_ANY_ID, PCI_ANY_ID, 0, 0, VIA_PRO_GROUP_A}, \
>> +       {0x1106, 0x1122, PCI_ANY_ID, PCI_ANY_ID, 0, 0, VIA_DX9_0}, \
>>        {0, 0, 0}
>>
>>  #define i810_PCI_IDS \
>> _
>>
>> ------------------------------------------------------------------------------
>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
>> trial. Simplify your report design, integration and deployment - and focus on
>> what you do best, core application coding. Discover what's new with
>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>> --
>> _______________________________________________
>> Dri-devel mailing list
>> Dri...@li...
>> https://lists.sourceforge.net/lists/listinfo/dri-devel
>>
>>     
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> --
> _______________________________________________
> Dri-devel mailing list
> Dri...@li...
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>