From: Dave A. <ai...@li...> - 2009-10-28 03:43:22
|
> > > DrNick on irc suggested just doing: > > if (is_compat_task()) ptr &= 0x00000000FFFFFFFF; > > > > Is there a one liner I can just do in the actual ioctls instead of > > adding 20 compat > > ones? > > Just do the right thing and pass all userland compat pointers > through the correct compat_*() macros. I wondered why the other ioctls worked, (uint32_t __user *)(unsigned long)card_res->fb_id_ptr; we already opencoded this (probably before it was macroisied or we just pasted it), so the radeon one is buggy, I should just go and compat_* all of these then and we should be all happy? Dave. |