Re: RFC: Porting radeonhds HDMI support to KMS

[Rafał M. <za...@gm...>]

2009/9/27 Christian König <dea...@vo...>:
> since i didn't got so much todo in the last week than i thought i would,
> i finally sit down and ported the HDMI support for R600 and up chipsets
> from radeonhd to KMS.
>
> So the attached patch is based on Dave Airlies drm-next tree
> (http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=shortlog;h=drm-next).
>
> It's been a while since i last coded inside kernel space and the patch
> is not very well tested, so there are quite a bunch of "TODO"s inside
> the code, but at least it's a starting point and seems to work fine with
> the radeon driver+KMS.
>
> So any comments or test results would be very welcome.

It doesn't work for me, and sorry but I'm too dumb to fix that :(

Playback speed in mplayer is alright, but my AV doesn't get any audio signal.

--- kms.playing.broken.dump.log 2009-09-28 16:06:00.000000000 +0200
+++ radeonhd.playing.dump.log   2009-09-28 14:21:51.000000000 +0200
@@ -5,8 +5,8 @@
 0x0518: 0x00E297D0
 0x051C: 0x00000000
 0x0520: 0x00000070
-0x0524: 0x00249F00
-0x0528: 0x008719F0
+0x0524: 0x00000000
+0x0528: 0x00000000
 0x052C: 0x00000000
 0x0530: 0x00000070
 0x0534: 0x00000000
@@ -24,7 +24,7 @@
 0x7388: 0x00010001
 0x738C: 0x00020002
 0x7390: 0x00000001
-0x7394: 0x00020070
+0x7394: 0x00060040
 0x7398: 0x00000001
 0x739C: 0x00000009
 0x73A0: 0x00000201

It seems KMS set also second pair of registers, probably for my LVDS
(PANEL). No reason for that, but shouldn't hurt, right?

I don't know meaning of
R600_AUDIO_SUPPORTED_SIZE_RATE (0x7394)
is this something important?

I've tried
rhd_dump -w 0524: 0x00000000 1:00.0
rhd_dump -w 0528: 0x00000000 1:00.0
rhd_dump -w 7394: 0x00060040 1:00.0
but it didn't help.

It reminds me RV770 issue from radeonhd, where we don't get working
audio. All registers are 100% alright, but no sound.

Maybe order of setting registers matters? Do we set registers in
different order than radeonhd does?

Please, check attached log files. In both cases I've started playback
*just once*. In case of radeonhd there is one
RHDHdmiUpdateAudioSettings operation. However KMS prints 4*playing
messages.

-- 
Rafał