Re: [Patch 4/4] DRM/I915: Add the default mode for CRT output without EDID

[Dave A. <ai...@re...>]

On Thu, 2009-09-03 at 09:33 +0800, yak...@in... wrote:
> From: Zhao Yakui <yak...@in...>
> 
> Add the default mode for the CRT output without EDID. But we only add the mode
> which visible part is equal to or less than 1024x768.

Use 800x600 as the default mode for consistency with X sake, this case
should be handled by the main drm code when it finds no modes anyways,
it possibly should be done in a helper.

Dave.

> 
> Signed-off-by: Zhao Yakui <yak...@in...>
> ---
>  drivers/gpu/drm/i915/intel_crt.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> Index: linux-2.6/drivers/gpu/drm/i915/intel_crt.c
> ===================================================================
> --- linux-2.6.orig/drivers/gpu/drm/i915/intel_crt.c	2009-09-03 08:56:50.000000000 +0800
> +++ linux-2.6/drivers/gpu/drm/i915/intel_crt.c	2009-09-03 09:28:35.000000000 +0800
> @@ -458,6 +458,14 @@
>  	intel_i2c_destroy(ddcbus);
>  
>  end:
> +	if (!ret) {
> +		/*
> + 		 * when there is no EDID, add some default modes.
> +		 * But the hdisplay should not be greater than 1024.
> +		 * the vdisplay should not be greater than 768
> +		 */
> +		ret = drm_add_modes_noedid(connector, 1024, 768);
> +	}
>  	return ret;
>  
>  }