From: <bug...@bu...> - 2009-03-24 09:46:02
|
http://bugzilla.kernel.org/show_bug.cgi?id=12920 ------- Comment #8 from mi...@el... 2009-03-24 02:45 ------- testing latest -tip would be useful: http://people.redhat.com/mingo/tip.git/README in particular the fix below has a chance of resolving it. Ingo ----------------> >From 9cdec049389ce2c324fd1ec508a71528a27d4a07 Mon Sep 17 00:00:00 2001 From: Pallipadi, Venkatesh <ven...@in...> Date: Mon, 23 Mar 2009 12:07:20 -0700 Subject: [PATCH] x86, PAT, PCI: Change vma prot in pci_mmap to reflect inherited prot While looking at the issue in the thread: http://marc.info/?l=dri-devel&m=123606627824556&w=2 noticed a bug in pci PAT code and memory type setting. PCI mmap code did not set the proper protection in vma, when it inherited protection in reserve_memtype. This bug only affects the case where there exists a WC mapping before X does an mmap with /proc or /sys pci interface. This will cause X userlevel mmap from /proc or /sysfs to fail on fork. Reported-by: Kevin Winchester <kjw...@gm...> Signed-off-by: Venkatesh Pallipadi <ven...@in...> Signed-off-by: Suresh Siddha <sur...@in...> Cc: Jesse Barnes <jb...@vi...> Cc: Dave Airlie <ai...@re...> Cc: <st...@ke...> LKML-Reference: <200...@li...> Signed-off-by: Ingo Molnar <mi...@el...> --- arch/x86/pci/i386.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c index 5ead808..f234a37 100644 --- a/arch/x86/pci/i386.c +++ b/arch/x86/pci/i386.c @@ -319,6 +319,9 @@ int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma, return -EINVAL; } flags = new_flags; + vma->vm_page_prot = __pgprot( + (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK) | + flags); } if (((vma->vm_pgoff < max_low_pfn_mapped) || -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |